3.4 Improvement - show executed 0ms nodes as 1ms #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reddyashish
reviewed
Sep 30, 2024
TuneUp/ProfiledNodeViewModel.cs
Outdated
| /// </summary> | ||
| public TimeSpan ExecutionTime | ||
| public int ExecutionMilliseconds |
There was a problem hiding this comment.
This would be an API break, changing name or return type of public property.
reddyashish
reviewed
Sep 30, 2024
| /// </summary> | ||
| public int ExecutionMilliseconds | ||
| public int GroupExecutionMilliseconds |
There was a problem hiding this comment.
Thanks, I think this should be okay now.
This reverts commit 22828b1.
reddyashish
approved these changes
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small PR to address one of the points for improvement in this Mural board (don't think there is a JIRA ticket for this) :
In
OnNodeExecutionEnd, theTimeSpanvalue is now rounded and directly assigned toExecutionMillisecondsas an integer. Total group execution times are calculated as the sum of these integer values rather than exactTimeSpanvalues. Consequently, theGroupExecutionTimeandExecutionTimeproperties are now obsolete and removed.