TuneUp - User facing strings moved to Resources #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
resources created but TuneUp does not show in context menu
uses the style from Dynamo when Export to CSV cannot overwrite a locked file
|
... Also added the Tooltips and ShowGroups is enabled by default. |
|
Once resources are added, when you build TuneUp, do you get additional files other than just the dll? Can you give a screen shot |
reddyashish
reviewed
Oct 18, 2024
|
@QilongTang, after adding en-US, I now see a new folder with TuneUp.resources.dll created during the build. 
|
|
@ivaylo-matov Can you touch https://github.com/DynamoDS/TuneUp/blob/master/pipeline.yml#L31 to also include the new folder in the zip file? |
reddyashish
approved these changes
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR to address a request from #66
Adds localization support. Hardcoded user-facing strings are extracted and moved to resources.
Also uses
MessageBoxService.Show()to change the style or error message whenExportToCSVcannot overwrite a locked file.This addresses a request in DYN-7436
@reddyashish
@QilongTang
@dnenov