Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New paths for pipeline.yml #74

Merged
merged 1 commit into from
Oct 31, 2024

Conversation

ivaylo-matov
Copy link
Contributor

@ivaylo-matov ivaylo-matov commented Oct 31, 2024

PR aims to address:

  • pipeline.yml script isn't generating TuneUp.zip with TuneUp.dll and en-US resources. I tested this locally in PowerShell using:
    Compress-Archive -Path "TuneUp\bin\Release\net8.0-windows\TuneUp.dll", "TuneUp\bin\Release\net8.0-windows\en-US" -DestinationPath "TuneUp.zip" which created TuneUp.zip, therefore this command:
    Compress-Archive -Path 'TuneUp/bin/Release/net8.0-windows/TuneUp.dll', 'TuneUp/bin/Release/net8.0-windows/en-US' -DestinationPath 'TuneUp.zip' should also work in the pipeline.

  • The Resources.en-US.Designer.cs file was not generating as expected. Renaming Resources.en-US.resx, running the custom tool, and renaming it back resolved the issue.

  • Fixed a typo in the resources file.

@QilongTang
@reddyashish
@dnenov

@QilongTang QilongTang merged commit 21721ef into DynamoDS:master Oct 31, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants