[DYN-7698] Zoom to group, doesn't work #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reddyashish
reviewed
Nov 1, 2024
| @@ -610,20 +613,16 @@ private void CreateGroupNodesForCollection(ObservableCollection<ProfiledNodeView | |||
| var pGroup = new ProfiledNodeViewModel(pNode) | |||
| { | |||
| GroupExecutionOrderNumber = executionCounter++, | |||
| GroupExecutionMilliseconds = groupExecTime | |||
| GroupExecutionMilliseconds = groupExecTime, | |||
There was a problem hiding this comment.
Can you add some comments here to provide why we need nodesToAdd here?.
I thought this was fixed by DynamoDS/Dynamo#15547
There was a problem hiding this comment.
I've written in the description that I couldn't build from master so I created this branch from DYN-7697-Crash-with-Periodic-Run as it was the latest I've published (the branch of #15547). Relevant changes to this ticket are only in CreateGroupNodesForCollection.
reddyashish
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR aims to address DYN-7698 where TuneUp does not zoom-to-fit on groups after that graph has been executed.
*This branch is built from
DYN-7697-Crash-with-Periodic-Runas I couldn't buildmaster. Relevant changes are only inCreateGroupNodesForCollection.@QilongTang
@reddyashish
@dnenov