Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conditionally Couple Wave Fields based on COMPSET #6885

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

erinethomas
Copy link
Contributor

@erinethomas erinethomas commented Jan 9, 2025

There is a issue in E3SM where the coupler history files contain wave variables even in compsets with NO active wave component. This PR fixes the issue by making all coupled wave fields "conditional" on the existence of an active wave component.
This PR produces BFB results in standard B cases with no active waves apart from the differing field list.

This PR adds a drv_in namelist variable called "wav_ocn_coup". This variable controls the coupling between the wave and ocean components. "wav_ocn_coup" is automatically defined (no user input is required) with one of the following: "none", "one" or "two" - based on the active components in the selected COMPSET.

For example, a B case with active WW3 automatically sets the wav_ocn_coup to "two" (full two-way coupling enabled between waves and ocean). However, a standard B case with no WW3 sets "wav_ocn_coup to "none" where no wave-ocean coupling is defined in the model.

Note: This framework is flexible enough to allow future capabilities of wave coupling. For example, in compsets where a data model is used, wav_ocn_coup could be set to "one", to enable one way coupling (passing information from a data model to active wave component). Furthermore, this framework will be expanded upon in the future to allow one and two way coupling between wave-atmosphere, as well as wave-sea ice components.

@erinethomas erinethomas added mpas-ocean BFB PR leaves answers BFB Wave labels Jan 9, 2025
@erinethomas erinethomas requested review from liho745, sbrus89 and jonbob and removed request for liho745 January 9, 2025 23:06
@erinethomas erinethomas added the non-BFB PR makes roundoff changes to answers. label Jan 9, 2025
@erinethomas erinethomas changed the title Wave Fields are CONDITIONALLY coupled based on COMPSET Conditionally Couple Wave Fields based on COMPSET Jan 9, 2025
@erinethomas erinethomas force-pushed the ww3/conditional_wave_cpl_hist_fields branch from decae62 to 6acbf9e Compare January 9, 2025 23:25
@liho745
Copy link
Contributor

liho745 commented Jan 10, 2025 via email

@erinethomas erinethomas force-pushed the ww3/conditional_wave_cpl_hist_fields branch from 6acbf9e to ba5f2ff Compare February 3, 2025 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BFB PR leaves answers BFB Coupler mpas-ocean non-BFB PR makes roundoff changes to answers. Wave
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants