Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update generate_domain_files_E3SM.py #6968

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

whannah1
Copy link
Contributor

@whannah1 whannah1 commented Feb 3, 2025

Add support for 2D grids needed for tri-grid configurations.

[BFB]

@whannah1 whannah1 added the inputdata Changes affecting inputdata collection on blues label Feb 3, 2025
@whannah1 whannah1 requested review from jonbob and brhillman February 3, 2025 20:44
@whannah1
Copy link
Contributor Author

whannah1 commented Feb 4, 2025

After pushing the latest bug fixes I got confirmation from Alan Di Vittorio that this resolves the issue he was having with his tri-grid configurations.

Copy link
Contributor

@jonbob jonbob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved based on testing -- domain files made from map_SOwISC12to30E3r4_to_r05_traave.20250122.nc were BFB with ones generated earlier with the Fortran version. The r05 should mean this tests the 2D domain feature

@singhbalwinder singhbalwinder changed the title update generate_domain_files_E3SM.py Update generate_domain_files_E3SM.py Feb 6, 2025
@singhbalwinder singhbalwinder added the BFB PR leaves answers BFB label Feb 6, 2025
singhbalwinder added a commit that referenced this pull request Feb 6, 2025
Update generate_domain_files_E3SM.py

Add support for 2D grids needed for tri-grid configurations.

[BFB]

* whannah/gen-domain-2D-grid-support:
  bug fix
  add output format spec for generate_domain_files_E3SM
  update generate_domain_files_E3SM.py to support 2D grids
@singhbalwinder
Copy link
Contributor

Merged to next

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BFB PR leaves answers BFB inputdata Changes affecting inputdata collection on blues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants