Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ZM cleanup - create zm_micropysics_state module #6973

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

ZM cleanup - create zm_micropysics_state module #6973

wants to merge 2 commits into from

Conversation

whannah1
Copy link
Contributor

@whannah1 whannah1 commented Feb 5, 2025 •
edited by singhbalwinder
Loading

Create a new module to contain methods for the ZM microphysics derived type (zm_microp_st).

[BFB]

@whannah1 whannah1 added Atmosphere BFB PR leaves answers BFB ZM labels Feb 5, 2025
@whannah1 whannah1 requested a review from crterai February 5, 2025 00:24
@whannah1
Copy link
Contributor Author

whannah1 commented Feb 5, 2025

The following tests pass on Chrysalis:

  e3sm_atm_developer_intel
  e3sm_atm_developer_gnu
  SMS_Ld32.ne30pg2_r05_oECv3.F2010.chrysalis_intel
  SMS_Ld32.ne30pg2_r05_oECv3.F2010.chrysalis_gnu
  SMS_Ld32.ne4pg2_oQU480.F2010.chrysalis_intel
  SMS_Ld32.ne4pg2_oQU480.F2010.chrysalis_gnu

Although I wasn't sure if the performance would be identical due to the change of the allocation method, but it seems this change was insignificant in terms of performance because the ZM timers of the SMS_Ld32 tests show no change, as shown below.

SMS_Ld32.ne30pg2_r05_oECv3.F2010.chrysalis_intel:

          name                                            on  processes  threads        count      walltotal   wallmax (proc   thrd  )   wallmin (proc   thrd  )
    base: "a:zm_conv_tend"                                 -        128      256 2.360832e+06   1.569556e+04    71.215 (     6      0)    51.286 (    27      0)
    test: "a:zm_conv_tend"                                 -        128      256 2.360832e+06   1.569556e+04    71.215 (     6      0)    51.286 (    27      0)

SMS_Ld32.ne30pg2_r05_oECv3.F2010.chrysalis_gnu:

          name                                            on  processes  threads        count      walltotal   wallmax (proc   thrd  )   wallmin (proc   thrd  )
    base: "a:zm_conv_tend"                                 -        128      256 2.360832e+06   2.247872e+04    95.379 (     3      1)    79.251 (    51      1)
    test: "a:zm_conv_tend"                                 -        128      256 2.360832e+06   2.247872e+04    95.379 (     3      1)    79.251 (    51      1)

bogensch
bogensch approved these changes Feb 6, 2025
View reviewed changes
Copy link
Contributor

@bogensch bogensch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

singhbalwinder added a commit that referenced this pull request Feb 6, 2025
@singhbalwinder
Merge branch 'whannah/eam/zm-cleanup-04' into next (PR #6973)
b3720ed 
ZM cleanup - create zm_micropysics_state module

Create a new module to contain methods for the ZM microphysics derived
 type (zm_microp_st).

[BFB]

* whannah/eam/zm-cleanup-04:
  bug fixes
  create zm_microphysics_state module
@singhbalwinder
Copy link
Contributor

Merged to next

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bogensch bogensch bogensch approved these changes

@crterai crterai Awaiting requested review from crterai

Assignees

@singhbalwinder singhbalwinder

Labels
Atmosphere BFB PR leaves answers BFB ZM
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@whannah1 @singhbalwinder @bogensch