-
Notifications
You must be signed in to change notification settings - Fork 378
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix for frazil ice temperature tendency #6976
base: master
Are you sure you want to change the base?
Bugfix for frazil ice temperature tendency #6976
Conversation
This change was tested with a 30-year branch run from Nicole's v3.LR frazil porosity run. Comparison between the two runs is here: Minor changes between the two are summarized in E3SM-Ocean-Discussion#118 (comment) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving by code inspection and based on the testing described in E3SM-Ocean-Discussion#118 (comment).
Thanks @cbegeman!
@vanroekel, do you have time to review this? It's pretty simple. |
oops, I reviewed this, but forgot to put in the approval. Thanks for the nudge @xylar |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approving based on visual inspection and developer testing.
Add temperature tendency due to mixing of frazil meltwater with seawater:
When frazil ice melts in MPAS-Ocean it is a freshwater volume flux (not a virtual flux). As such, there should be two components to the temperature tendency due to frazil melt, a latent heat flux and a flux associated with the mixing of water at the freezing point with the ambient seawater. The latter was not included (a bug).
Fixes #6975
[non-BFB]