Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix for frazil ice temperature tendency #6976

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

cbegeman
Copy link
Contributor

@cbegeman cbegeman commented Feb 5, 2025

Add temperature tendency due to mixing of frazil meltwater with seawater:

When frazil ice melts in MPAS-Ocean it is a freshwater volume flux (not a virtual flux). As such, there should be two components to the temperature tendency due to frazil melt, a latent heat flux and a flux associated with the mixing of water at the freezing point with the ambient seawater. The latter was not included (a bug).

Fixes #6975
[non-BFB]

@cbegeman
Copy link
Contributor Author

cbegeman commented Feb 5, 2025

This change was tested with a 30-year branch run from Nicole's v3.LR frazil porosity run. Comparison between the two runs is here:
https://portal.nersc.gov/cfs/e3sm/cbegeman/analysis/20250116.Frazil2.underIce.bugfix.piControl.pm-cpu/mpas_analysis/ts_0051-0080_climo_0051-0080_polar/

Minor changes between the two are summarized in E3SM-Ocean-Discussion#118 (comment)

Copy link
Contributor

@xylar xylar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving by code inspection and based on the testing described in E3SM-Ocean-Discussion#118 (comment).

Thanks @cbegeman!

@xylar
Copy link
Contributor

xylar commented Feb 11, 2025

@vanroekel, do you have time to review this? It's pretty simple.

@vanroekel
Copy link
Contributor

oops, I reviewed this, but forgot to put in the approval. Thanks for the nudge @xylar

Copy link
Contributor

@vanroekel vanroekel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approving based on visual inspection and developer testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug fix PR mpas-ocean NCC Larger-then-roundoff diffs but not believed climate changing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Temperature flux due to frazil ice melting in seawater is incorrect
4 participants