-
Notifications
You must be signed in to change notification settings - Fork 377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EAMxx:Adds a fully coupled compset with EAMxx #6978
base: master
Are you sure you want to change the base?
Conversation
This is obviously a huge step forward over no testing of config. I agree with others that ERS might be better than SMS, but when I tried I also get the issue with archiving. I might suggest we also include ne30 coupled test Ideally, we could have DEBUG ne4 run on CPU, and OPT ne30 on GPU. Another detail is that coupled cases will fail to build using the default AMD compiler on frontier, so I've been testing with Cray compiler. I just don't want to delay getting some sort of test in |
i agree with ndk, how about we do the following:
|
The ERS test fails with archiving error |
The archive problem is probably because there's no eamxx entry in config_archive.xml. Its just "scream". There's needs to be a general scream->eamxx switch in the xml files and compset long names. |
Thanks all. Previously we talked about pruning the number of tests we run in the nightlies. @bartgol : Would it be okay if we add three new tests in the nightlies? |
Maybe we should add one simple test first so that we at least have the testing in place for this compset. We can add more if desired in another PR. |
I don't think we ever wanted to reduce the number of nightly tests. The discussion we had was about testing on CI resources/containers. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would change this to not be a DEBUG test. That is remove _D
.
And obviously no need for Ln5
at ne4.
And, I would just use ne30.
@singhbalwinder is this ready? |
A fully coupled test with ne4 grid is added that uses EAMxx as its atmosphere model.