Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update tests to support Omega time slices #276

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Update tests to support Omega time slices #276

wants to merge 4 commits into from

Conversation

xylar
Copy link
Collaborator

@xylar xylar commented Feb 4, 2025 •
edited
Loading

This merge Updates manufactured_solution, cosine_bell and sphere_transport tests to support time-slice capabilities brought in by E3SM-Project/Omega#189

Some incorrect task names in the omega_prsuite have also been fixed.

Checklist

  • Testing comment in the PR documents testing used to verify the changes

@xylar xylar added enhancement New feature or request in progress This PR is not ready for review or merging ocean Related to ocean tests or analysis Omega PR required The polaris changes won't work with the current Omega submodule and require an update labels Feb 4, 2025
@xylar xylar requested a review from cbegeman February 4, 2025 13:41
@xylar xylar self-assigned this Feb 4, 2025
@xylar
Copy link
Collaborator Author

xylar commented Feb 4, 2025

Testing

I ran the omega_pr suite on Chrysalis and all 4 tests passed.

cbegeman
cbegeman approved these changes Feb 4, 2025
View reviewed changes
Copy link
Collaborator

@cbegeman cbegeman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving based on visual inspection. @xylar Let me know if you would like me to do any testing.

@xylar
Copy link
Collaborator Author

xylar commented Feb 4, 2025

Thanks @cbegeman! This can't go in until the Omega changes go in but I'll take care of that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cbegeman cbegeman cbegeman approved these changes

Assignees

@xylar xylar

Labels
enhancement New feature or request in progress This PR is not ready for review or merging ocean Related to ocean tests or analysis Omega PR required The polaris changes won't work with the current Omega submodule and require an update
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xylar @cbegeman