[WIP] Interfacing 1D CurlCurl from AMReX #5662
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
debog
added
enhancement
|
Should we document the performance like I did for this PR? |
debog
reviewed
Feb 27, 2025
Comment on lines
+313
to
+318
| Array<MultiFab,3> solution { MultiFab(*x_mfarrvec[n][2], make_alias, 0, 1), | ||
| MultiFab(*x_mfarrvec[n][1], make_alias, 0, 1), | ||
| MultiFab(*x_mfarrvec[n][0], make_alias, 0, 1) }; | ||
| Array<MultiFab,3> rhs { MultiFab(*b_mfarrvec[n][2], make_alias, 0, 1), | ||
| MultiFab(*b_mfarrvec[n][1], make_alias, 0, 1), | ||
| MultiFab(*b_mfarrvec[n][0], make_alias, 0, 1) }; |
There was a problem hiding this comment.
Why did you map the AMReX to WarpX dimensions as 0,1,2 -> 2,1,0 and not 0,1,2 -> 2,0,1?
There was a problem hiding this comment.
This was clarified in a meeting based on the available documentation: https://warpx.readthedocs.io/en/latest/developers/dimensionality.html.
|
I think you can rebase this PR, the commit we fetch after #5699 is 044d52f7d309e340939d7cae449fd83209da317f, which seems to include AMReX-Codes/amrex#4331, if I'm not mistaken. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently needs to compile with AMReX-Codes/amrex#4331 if using cmake for 1D compilation
(Currently CI tests will fail since it uses amrex src that does not include the above PR)