CI: Add Workflow to Run Jupyter Notebooks #5696
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EZoni
force-pushed
the
ci_add_jupyter_notebooks
branch
from
21db2af to
4709f6e
Compare
EZoni
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a CI workflow where we can execute Jupyter notebooks without opening a web browser using nbconvert:
While discussing with @oshapoval about some recent PRs, we realized that one of the two PSATD notebooks available in Source/Tools/Algorithms/ needed an update to run without errors with the newest versions of SymPy (which introduced some stricter policies for mutable vs. immutable matrices). We did not catch this bug earlier because those notebooks were never executed automatically.
Notebooks added to the CI workflow:
psatd.ipynbpsatd_pml.ipynbMore notebooks (e.g., post-processing), whenever possible, can be added to the same CI workflow in the future.