CI: Ubuntu 22.04/24.04 in GitHub Actions, CUDA 11.7+ #5731

EZoni · 2025-03-04T17:49:56Z

The Ubuntu 20.04 runner image will be deprecated soon: actions/runner-images#11101.
Only support CUDA 11.7+ going forward.

To-do:

GitHub Actions workflows
~~Azure DevOps workflows~~ (transfered to [WIP]Update constants to use values from CODATA2022 #5661)

Notes

I renamed the following workflows, with the aim of not having to rename them again in the future when we upgrade version numbers:

NVCC 11.3 SP, now NVCC SP
NVCC 11.8.0 GNUmake, now NVC GNU Make
[email protected] NVCC/NVC++ Release [tests], now NVHPC

If you are okay with the renaming, the list of "required" workflows should be updated to reflect the new names, and I don't have the necessary access to do so.

EZoni · 2025-03-04T21:34:21Z

I see this error message from the Intel / oneAPI ICC SP&DP workflow:

icpc: remark #10441: The Intel(R) C++ Compiler Classic (ICC) is deprecated and will be removed from product release in the second half of 2023. The Intel(R) oneAPI DPC++/C++ Compiler (ICX) is the recommended compiler moving forward. Please transition to use this compiler. Use '-diag-disable=10441' to disable this message.

Is there a specific reason why we want to keep testing builds with ICC, even though it is deprecated since 2023?

EZoni · 2025-03-04T23:01:28Z

@ax3l @WeiqunZhang

Do you have insight on my question above, #5731 (comment)? I don't see ICC being used in AMReX CI workflows, if I'm not mistaken. If this is indeed obsolete, we can migrate this last ICC build in WarpX to ICX (DPC++) as well, or remove it if redundant.

.azure-pipelines.yml

Examples/Tests/open_bc_poisson_solver/inputs_test_3d_open_bc_poisson_solver

Examples/Tests/boundaries/analysis.py

Examples/Tests/implicit/analysis_vandb_jfnk_2d.py

dpgrote

Looks good to me! Thanks!

ax3l · 2025-03-07T01:31:23Z

.github/workflows/ubuntu.yml

@@ -101,7 +101,7 @@ jobs:

  build_3D_sp:
    name: GCC 3D & RZ w/ MPI, single precision
-    runs-on: ubuntu-22.04


I admittedly had intentionally a few 22.04 runners because it will cover older g++ and clang++ compilers that way.

Please revert this one.

Done in dac25b8.

ax3l · 2025-03-07T01:32:37Z

.github/workflows/intel.yml

@@ -18,7 +18,7 @@ jobs:
 # intel-basekit intel-hpckit are too large in size
  build_icc:
    name: oneAPI ICC SP&DP
-    runs-on: ubuntu-20.04
+    runs-on: ubuntu-24.04


Please remove the "old" ICC, it is EOL since mid 2023 and I already removed it from pyAMReX.
AMReX-Codes/pyamrex#409

Intel only supports ICX (oneAPI compilers) going forward. (The two we have below in this script.)

Done in 43e0a32.

Now that the oneAPI ICC SP&DP workflow job has been removed, it should aslo be removed from the list of "required" workflows in the repository settings by one of the owners.

ax3l · 2025-03-07T01:33:30Z

.github/workflows/post-pr.yml

@@ -10,7 +10,7 @@ on:

 jobs:
  noop:
-    runs-on: ubuntu-latest


I would keep -latest for this, because it will never need an update that way.

Please revert this one.

Done in 49a2603.

.readthedocs.yml

ax3l · 2025-03-07T01:36:46Z

.github/workflows/cuda.yml

-    name: NVCC 11.3 SP
-    runs-on: ubuntu-20.04
+    name: NVCC SP
+    runs-on: ubuntu-24.04


I would not go over 22.04, because that way we do not cover older CUDA compilers anymore and will likely loose compatibility.

Instead, please do something like this BLAST-ImpactX/impactx#869 and update our documentation that we only support CUDA 11.7+ now.

Okay, done in dd2fe9b.

The documentation does not seem to need any update, it already states 11.7+, if I'm not mistaken.

I initially chose to go for 12.6+ (and Ubuntu 24.04) because I saw that this is what they did in AMReX-Codes/amrex#4330 in AMReX.

In general isn't it a risk to mix Ubuntu 22.04 and Ubuntu 24.04 support in our CI coverage, i.e., don't we risk to have potentially holes in how we test compatibility? Shoudn't we then simply cover only Ubuntu 22.04 until it reaches EOL? I'm just trying to understand which of the two strategies, the mixed one we are setting up here or the single-version one they set up in AMReX, makes more sense, if any.

The documentation does not seem to need any update, it already states 11.7+, if I'm not mistaken.

ax3l

Please see inline comments and needed documentation changes for CUDA supported versions.

CI: upgrade Ubuntu version in GitHub Actions workflows

c6d7a48

EZoni added the component: tests Tests and CI label Mar 4, 2025

EZoni mentioned this pull request Mar 4, 2025

[WIP]Update constants to use values from CODATA2022 #5661

Open

NVCC 12.6

f60a2a4

EZoni force-pushed the ci_upgrade_ubuntu branch from e3088de to f60a2a4 Compare March 4, 2025 18:37

NVHPC 25.1

cbc0ccc

EZoni force-pushed the ci_upgrade_ubuntu branch from f7b6812 to cbc0ccc Compare March 4, 2025 19:10

EZoni added 3 commits March 4, 2025 12:57

Rename CUDA workflow jobs

95413a2

Debug GCC workflow job

34fc217

Debug Clang workflow job

ea7f703

EZoni force-pushed the ci_upgrade_ubuntu branch from fc7b511 to 239d529 Compare March 4, 2025 21:28

Clean up CUDA dependencies scripts

3de1574

EZoni force-pushed the ci_upgrade_ubuntu branch from 239d529 to 3de1574 Compare March 4, 2025 21:45

EZoni added 3 commits March 4, 2025 14:03

Rename CUDA workflow jobs

4385402

Upgrade Ubuntu version in Read the Docs workflow

1048c8a

Upgrade Ubuntu version in Azure DevOps workflows

5d77c8e

EZoni commented Mar 4, 2025

View reviewed changes

.azure-pipelines.yml Outdated Show resolved Hide resolved

Fix 1D tests

faae0a3

EZoni force-pushed the ci_upgrade_ubuntu branch from fda02d1 to 2771fe4 Compare March 5, 2025 04:49

Fix 2D tests

8d4ab7a

EZoni force-pushed the ci_upgrade_ubuntu branch from 87c1f66 to 8d4ab7a Compare March 5, 2025 18:22

EZoni commented Mar 5, 2025

View reviewed changes

.azure-pipelines.yml Outdated Show resolved Hide resolved

Fix 3D tests

7e3e239

EZoni commented Mar 5, 2025

View reviewed changes

Examples/Tests/open_bc_poisson_solver/inputs_test_3d_open_bc_poisson_solver Outdated Show resolved Hide resolved

EZoni mentioned this pull request Mar 5, 2025

Release 25.03 #5734

Merged

Fix RZ tests

ed02ef0

EZoni force-pushed the ci_upgrade_ubuntu branch from 4d90f1b to 694fce6 Compare March 6, 2025 00:30

Fix test_3d_particle_boundaries

89c2af4

EZoni force-pushed the ci_upgrade_ubuntu branch from 694fce6 to 89c2af4 Compare March 6, 2025 01:36

EZoni commented Mar 6, 2025

View reviewed changes

Examples/Tests/boundaries/analysis.py Outdated Show resolved Hide resolved

dpgrote reviewed Mar 6, 2025

View reviewed changes

Examples/Tests/implicit/analysis_vandb_jfnk_2d.py Outdated Show resolved Hide resolved

Revert changes to Azure DevOps CI tests

e3d274d

EZoni changed the title ~~[WIP] CI: upgrade Ubuntu version~~ [WIP] CI: Ubuntu 24.04 in GitHub Actions Workflows Mar 6, 2025

EZoni requested review from dpgrote, WeiqunZhang and ax3l March 6, 2025 19:36

EZoni changed the title ~~[WIP] CI: Ubuntu 24.04 in GitHub Actions Workflows~~ CI: Ubuntu 24.04 in GitHub Actions Workflows Mar 6, 2025

EZoni requested a review from atmyers March 6, 2025 21:43

dpgrote approved these changes Mar 7, 2025

View reviewed changes

This comment was marked as outdated.

Sign in to view

ax3l reviewed Mar 7, 2025

View reviewed changes

.readthedocs.yml Show resolved Hide resolved

ax3l reviewed Mar 7, 2025

View reviewed changes

ax3l requested changes Mar 7, 2025

View reviewed changes

ax3l changed the title ~~CI: Ubuntu 24.04 in GitHub Actions Workflows~~ CI: Ubuntu 22.04/24.04 in GitHub Actions Workflows Mar 7, 2025

ax3l added component: documentation Docs, readme and manual install backend: cuda Specific to CUDA execution (GPUs) labels Mar 7, 2025

ax3l changed the title ~~CI: Ubuntu 22.04/24.04 in GitHub Actions Workflows~~ CI: Ubuntu 22.04/24.04 in GitHub Actions, CUDA 11.7+ Mar 7, 2025

EZoni added 5 commits March 6, 2025 21:57

Revert to Ubuntu 22.04 in OpenMP workflow

dac25b8

Remove ICC build in Intel workflow

43e0a32

Revert to Ubuntu latest in PostPR workflow

49a2603

Revert to Ubuntu 22.04 in CUDA workflow

dd2fe9b

Merge 'ECP-WarpX:development' into 'EZoni:ci_upgrade_ubuntu'

aa1be99

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

CI: Ubuntu 22.04/24.04 in GitHub Actions, CUDA 11.7+ #5731

CI: Ubuntu 22.04/24.04 in GitHub Actions, CUDA 11.7+ #5731

EZoni commented Mar 4, 2025 •

edited

Loading

EZoni commented Mar 4, 2025

EZoni commented Mar 4, 2025 •

edited

Loading

dpgrote left a comment

This comment was marked as outdated.

ax3l Mar 7, 2025

ax3l Mar 7, 2025

EZoni Mar 7, 2025

ax3l Mar 7, 2025 •

edited

Loading

EZoni Mar 7, 2025

EZoni Mar 7, 2025

ax3l Mar 7, 2025

ax3l Mar 7, 2025

EZoni Mar 7, 2025

ax3l Mar 7, 2025

EZoni Mar 7, 2025

EZoni Mar 7, 2025

ax3l left a comment

CI: Ubuntu 22.04/24.04 in GitHub Actions, CUDA 11.7+ #5731

Are you sure you want to change the base?

CI: Ubuntu 22.04/24.04 in GitHub Actions, CUDA 11.7+ #5731

Conversation

EZoni commented Mar 4, 2025 • edited Loading

Notes

EZoni commented Mar 4, 2025

EZoni commented Mar 4, 2025 • edited Loading

dpgrote left a comment

Choose a reason for hiding this comment

This comment was marked as outdated.

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ax3l Mar 7, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ax3l left a comment

Choose a reason for hiding this comment

EZoni commented Mar 4, 2025 •

edited

Loading

EZoni commented Mar 4, 2025 •

edited

Loading

ax3l Mar 7, 2025 •

edited

Loading