-
-
Notifications
You must be signed in to change notification settings - Fork 388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Add new heuristic for fingerprinting detection. #1505
Draft
cowlicks
wants to merge
8
commits into
EFForg:master
Choose a base branch
from
cowlicks:finger-counting
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 16, 2017
Closed
ghostwords
added
enhancement
heuristic
Badger's core learning-what-to-block functionality
labels
Aug 2, 2017
Hi @cowlicks, I merged this branch in my fork, I'll just report in this PR the issues I encounter. The one above happen with this branch merged in master, navigating on http://www.gettvstreamnow.com/ |
What browser are you using, and what version? What happens if you run this in a the page: Object.defineProperty(window, 'sessionStorage', {get: function() {console.log('stuff')}});
window.sessionStorage |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
fingerprinting
Relating to (canvas) fingerprinting detection
heuristic
Badger's core learning-what-to-block functionality
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have list of methods commonly used by browser fingerprinting tools. We wrap each of these in a counter to track their usage. When an origin uses more than some threshold percentage (currently %75) of the methods, we say it is fingerprinting.
I set the %75 value empirically from testing. The highest percentage I saw on a non-fingerprinting site was 45% (github), the lowest I saw on a fingerprinting site was 80% (this site has since gone down).
There are currently some architectural issue with privacy badger which should be fixed before merging this. Mainly: This kind of tracking should not be associated with an origin, instead it should be associated with a URL (or some notion of it). It makes sense for cookies to be associated with an origin, because that is how cookies are scoped. But this tracking is normally loaded from a standalone library that could be anywhere, like a third party CDN service or the first party.
If we block origins associated with fingerprinting, we'll end up blocking CDN's, which breaks other sites, which means we'll manually have to add the sites to the cookieblock list, which will just allow the fingerprinting to continue. I'll expand more on this in a separate issue.