Strip UTM parameters from third-party https requests #2162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcyphers
force-pushed
the
strip-utm-params
branch
from
d0b5f1c
to
5a04219
Compare
|
Again, the test failure comes from a timeout. I'll rebase in order to trigger the tests again. |
...and all main-frame requests. Leave first-party background requests and private or social widget requests alone.
bcyphers
force-pushed
the
strip-utm-params
branch
from
726e16a
to
c3fb885
Compare
|
And now this: |
|
Might be worth handling |
|
We just got a PR to remove "fbclid" from outgoing Facebook links as part of existing Facebook link cleaning: #2207. |
|
Also worth removing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#681 (comment)
Strip Urchin Tracking Module (UTM) parameters from URLs in main-frame and third-party background requests. Only operate on https:// urls to avoid conflicts with HTTPSE. Leave first-party background requests and private or social widget requests alone.