Improve startup #2438
Merged
Improve startup #2438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcyphers
reviewed
Oct 29, 2019
src/js/webrequest.js
Outdated
| * @returns {Object} | ||
| */ | ||
| function onBeforeReady(details) { | ||
| if (!pendingTabs || details.tabId < 0) { |
There was a problem hiding this comment.
when would pendingTabs be falsey here?
There was a problem hiding this comment.
We set pendingTabs to null at the end of reloadPendingTabs(). Is it possible to still have requests queued for onBeforeReady() after stopBeforeReadyListener() is called? I would have to look into it.
There was a problem hiding this comment.
We may want to ignore "main_frame" resources to avoid running into gorhill/uBlock#3130
ghostwords
commented
Oct 31, 2019
src/js/webrequest.js
Outdated
| } | ||
|
|
||
| function stopBeforeReadyListener() { | ||
| chrome.webRequest.onBeforeRequest.removeListener(onBeforeReady); |
There was a problem hiding this comment.
Should the listener not be removed for it to be treated as "persistent" by Firefox? See uBlockOrigin/uBlock-issues#128 (comment)
ghostwords
force-pushed
the
improve-startup
branch
from
4b92622
to
47dbaba
Compare
This was referenced Nov 1, 2019
ghostwords
force-pushed
the
improve-startup
branch
from
0de95d8
to
74d2ec9
Compare
Conflicts: src/js/background.js
ghostwords
force-pushed
the
improve-startup
branch
from
74d2ec9
to
91c5f26
Compare
Called in a loop on (seed) data import.
Removes a getBaseDomain() call from a loop.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #1845.
badger.INITIALIZEDto account for asynchronous initialization tasks (such as seed data loading). This removes the need for workarounds in places that care about Badger being fully initialized (might want to keep them though in badger-sett for a while longer to enable running with Badgers that won't have this fix).Sets up an earlychrome.onBeforeRequestlistener to cancel all requests before Badger is done initializing. Reloads the tabs for the cancelled requests upon Badger being ready. (fb68766, 0de95d8) This should be guaranteed to catch all requests on startup in Firefox thanks to a "persistent" listener, and should catch more requests on startup in Chrome thanks to initializing a blocking listener faster.