Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Community learning discussion draft #2715

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Community learning discussion draft #2715

wants to merge 9 commits into from

Commits on Oct 14, 2020

  1. Pass tracker type to _recordPrevalence

    @bcyphers
    bcyphers committed Oct 14, 2020
    Configuration menu
    Copy the full SHA
    7a8de57 View commit details
    Browse the repository at this point in the history

  2. Call function to share tracker data with EFF when community learning … 

    …is enabled

- Create new SettingsMap variable, shareLearning, and default to false
- pass tab_id to _recordPrevalence so that it can determine whether learning is enabled on a tab
- update isLearningEnabled so that it returns true if either local or community learning is enabled;
  let _recordPrevalence figure out which kind of learning should be done
- Create stub for function to share data with remote server
    @bcyphers
    bcyphers committed Oct 14, 2020
    Configuration menu
    Copy the full SHA
    0cef67e View commit details
    Browse the repository at this point in the history

Commits on Oct 19, 2020

  1. Add reporting code to maybeShareTracker, fix syntax errors

    @bcyphers
    bcyphers committed Oct 19, 2020
    Configuration menu
    Copy the full SHA
    c7e0ed3 View commit details
    Browse the repository at this point in the history

  2. Remove call to updateTrackerPrevalence from BadgerStorage.merge 

    Since _recordPrevalence now checks for local learning enabled internally,
update BadgerStorage.merge() to modify the blocklist directly.
    @bcyphers
    bcyphers committed Oct 19, 2020
    Configuration menu
    Copy the full SHA
    d19ab03 View commit details
    Browse the repository at this point in the history

  3. more local learning code is behind if statement

    @bcyphers
    bcyphers committed Oct 19, 2020
    Configuration menu
    Copy the full SHA
    e55e0a3 View commit details
    Browse the repository at this point in the history

  4. Add community learning to options page

    @bcyphers
    bcyphers committed Oct 19, 2020
    Configuration menu
    Copy the full SHA
    c0c1467 View commit details
    Browse the repository at this point in the history

Commits on Oct 27, 2020

  1. send host instead of origin 

    update some comments
    @bcyphers
    bcyphers committed Oct 27, 2020
    Configuration menu
    Copy the full SHA
    9d537a6 View commit details
    Browse the repository at this point in the history

Commits on Oct 28, 2020

  1. Create in-memory cache to prevent duplicate reports

    @bcyphers
    bcyphers committed Oct 28, 2020
    Configuration menu
    Copy the full SHA
    85bfd6b View commit details
    Browse the repository at this point in the history

  2. Do not do community learning in incognito windows

    @bcyphers
    bcyphers committed Oct 28, 2020
    Configuration menu
    Copy the full SHA
    86432ed View commit details
    Browse the repository at this point in the history