Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update widget exceptions to be an "always activate" list #3047

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ghostwords
Copy link
Member

Fixes #3007. Needs a DNR patch for MV3.

Copy link
Contributor

@lenacohen lenacohen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and LGTM! Left one minor code suggestion

@ghostwords ghostwords force-pushed the fix-widget-exceptions branch from a695350 to 7d558e1 Compare February 4, 2025 14:55
Instead of a "keep blocking but don't replace" list.
@ghostwords ghostwords force-pushed the fix-widget-exceptions branch from 7d558e1 to bc77239 Compare February 4, 2025 22:11
@ghostwords
Copy link
Member Author

Ugh, we may want to instead add "always activate" while keeping "block but don't replace".

https://bsky.app/profile/hopelong.bsky.social/post/3lhiysh6rss2u

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Widget Exceptions" are confusing
2 participants