fix: Add Missing logout in signup tests to reset user session #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the auth module unit tests, there is an issue in the signup tests where the user session is not reset after successfully signing up, which causes unexpected behavior in subsequent tests. This happens because, during a successful signup, the login_user() function is called, leaving the user logged in. However, unlike the login tests, there is no logout action to clear the session after each signup test.
I added a test_client.get("/logout", follow_redirects=True) call after the assertions in the signup tests, ensuring that each following test starts with an unauthenticated session.