-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixate DLite-Python and tripper so that nothing fails in master. #330
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #330 +/- ##
=========================================
Coverage ? 88.30%
=========================================
Files ? 15
Lines ? 607
Branches ? 0
=========================================
Hits ? 536
Misses ? 71
Partials ? 0 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cheers - this was my initial solution to things as well, and has been everywhere else.
For future reference, to whomever comes around here again to check what this fix is related to, it is this: #327. Note, this PR is a temporary fix. However, once SINTEF/dlite#1087 has been fixed (and new releases are done for both DLite and tripper), the issue should be resolved.
Description:
Type of change:
Checklist for the reviewer:
This checklist should be used as a help for the reviewer.