Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixate DLite-Python and tripper so that nothing fails in master. #330

Merged
merged 7 commits into from
Jan 28, 2025

Conversation

francescalb
Copy link
Contributor

@francescalb francescalb commented Jan 22, 2025

Description:

Type of change:

  • Bug fix.
  • New feature.
  • Documentation update.

Checklist for the reviewer:

This checklist should be used as a help for the reviewer.

  • Is the change limited to one issue?
  • Does this PR close the issue?
  • Is the code easy to read and understand, including clearly named variables?
  • Do all new feature have an accompanying new test?
  • Has the documentation been updated as necessary?

@francescalb francescalb marked this pull request as draft January 22, 2025 15:27
Copy link

codecov bot commented Jan 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (master@a24efd4). Learn more about missing BASE report.
Report is 19 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #330   +/-   ##
=========================================
  Coverage          ?   88.30%           
=========================================
  Files             ?       15           
  Lines             ?      607           
  Branches          ?        0           
=========================================
  Hits              ?      536           
  Misses            ?       71           
  Partials          ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@francescalb francescalb changed the title stop pytest from failing Fixate DLite-Python and tripper so that nothing fails in master. Jan 24, 2025
@francescalb francescalb marked this pull request as ready for review January 24, 2025 15:04
@francescalb francescalb requested a review from CasperWA January 28, 2025 07:05
Copy link
Contributor

@CasperWA CasperWA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cheers - this was my initial solution to things as well, and has been everywhere else.

For future reference, to whomever comes around here again to check what this fix is related to, it is this: #327. Note, this PR is a temporary fix. However, once SINTEF/dlite#1087 has been fixed (and new releases are done for both DLite and tripper), the issue should be resolved.

@francescalb francescalb merged commit e87eb7d into master Jan 28, 2025
14 checks passed
@francescalb francescalb deleted the flb/pytest_fails branch January 28, 2025 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants