Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flb/passing instances dlite0.5.24 #331

Open
wants to merge 13 commits into
base: master
Choose a base branch
from

Conversation

francescalb
Copy link
Contributor

@francescalb francescalb commented Jan 24, 2025

Description:

Going from version 0.5.23 to 0.5.24 of DLite several memory leakages were fixed.
As a result, we now get a problem with passing of instances from one strategy to the next, since as soon as the collection goes out of scope it is removed and references are missing.

I suggest this workaround for now, in which refcount is increased "manually" in the convert function when a new instance is added.

I do not understand why it works for the parse and not the generate function though.

The test fails now because of numpy issues which will be fixed with tripper being updated. Tripper0.3.5 updates pint to 0.24 which is numpy2 compatible.

Removing the focing warnings to errors is done because update of SWIG creates a deprecation warning. It is part of their plan for the next release to resolve this.

Type of change:

  • Bug fix.
  • New feature.
  • Documentation update.

Checklist for the reviewer:

This checklist should be used as a help for the reviewer.

  • Is the change limited to one issue?
  • Does this PR close the issue?
  • Is the code easy to read and understand, including clearly named variables?
  • Do all new feature have an accompanying new test?
  • Has the documentation been updated as necessary?

@francescalb francescalb marked this pull request as draft January 24, 2025 14:06
@francescalb francescalb marked this pull request as ready for review January 24, 2025 15:10
Copy link

codecov bot commented Jan 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.32%. Comparing base (e87eb7d) to head (fd190f9).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #331      +/-   ##
==========================================
+ Coverage   88.30%   88.32%   +0.01%     
==========================================
  Files          15       15              
  Lines         607      608       +1     
==========================================
+ Hits          536      537       +1     
  Misses         71       71              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant