-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flb/passing instances dlite0.5.24 #331
Open
francescalb
wants to merge
13
commits into
master
Choose a base branch
from
flb/passing_instances_Dlite0.5.24
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
francescalb
commented
Jan 24, 2025
francescalb
commented
Jan 24, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #331 +/- ##
==========================================
+ Coverage 88.30% 88.32% +0.01%
==========================================
Files 15 15
Lines 607 608 +1
==========================================
+ Hits 536 537 +1
Misses 71 71 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Going from version 0.5.23 to 0.5.24 of DLite several memory leakages were fixed.
As a result, we now get a problem with passing of instances from one strategy to the next, since as soon as the collection goes out of scope it is removed and references are missing.
I suggest this workaround for now, in which refcount is increased "manually" in the convert function when a new instance is added.
I do not understand why it works for the parse and not the generate function though.
The test fails now because of numpy issues which will be fixed with tripper being updated. Tripper0.3.5 updates pint to 0.24 which is numpy2 compatible.
Removing the focing warnings to errors is done because update of SWIG creates a deprecation warning. It is part of their plan for the next release to resolve this.
Type of change:
Checklist for the reviewer:
This checklist should be used as a help for the reviewer.