-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Have all strategy response types be AttrDict (not bytes) #134
base: master
Are you sure you want to change the base?
Conversation
Instead of bytes. By "all", is meant that all strategy methods that previously returned bytes, now return an oteapi.models.AttrDict. It is equivalent to a MutableMapping, but is also a pydantic BaseModel.
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #134 +/- ##
==========================================
+ Coverage 90.67% 90.74% +0.06%
==========================================
Files 26 26
Lines 429 432 +3
==========================================
+ Hits 389 392 +3
Misses 40 40
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
Makes me very queezy. I really dislike backwards-incompatible changes [if I am not mistaken] the benefit to me is not very clear. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unclear, need to think more. In general I am extremely biased against backwards-incompatible changes
That's completely fair. For the reasoning and any discussion about this I'd refer you to the issue this PR is trying to close: #86. Feel free to jump-start the discussion there with some thoughts. |
Description:
Closes #86
By "all", is meant that all strategy methods that previously returned bytes, now return an oteapi.models.AttrDict.
It is equivalent to a MutableMapping, but is also a pydantic BaseModel.
The demo notebook, as well as all the unit tests, have also been updated accordingly.
Type of change:
Checklist for the reviewer:
This checklist should be used as a help for the reviewer.