-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added units submodule for working with units and quantities defined in ontologies #324
Open
jesper-friis
wants to merge
25
commits into
master
Choose a base branch
from
units
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #324 +/- ##
==========================================
+ Coverage 76.83% 77.37% +0.53%
==========================================
Files 22 24 +2
Lines 2491 2718 +227
==========================================
+ Hits 1914 2103 +189
- Misses 577 615 +38 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added a new units submodule for working with units and quantities defined in ontologies.
The module provides support to populate a Pint units definition file from EMMO. It also subclasses
pint.UnitRegistry
,pint.Uni
, andpint.Quantity
, enhancing them with knowledge from the ontology.Currently it only supports EMMO as source. But it utilises the references to QUDT and OM such that it is possible to work with IRIs to these ontologies as well.
The PR includes tests and documentation.
Other fixes:
literal.py
Triplestore.value()
Triplestore.restrictions()
AttrDict
pickleableFollow-up tasks
Quantity
subclass should know about the ontological IRI corresponding to a Pint Quantity.Type of change
Checklist for the reviewer
This checklist should be used as a help for the reviewer.