Adding Search functionality to EPIC Guide

[vinitra]

Resolves #53, with a simple custom google toolbar, tied to the [email protected] address.

@basil-conto and I explored a couple Jekyll-based search options but they were hard to get working; this solution seems a lot easier and nicer!

[SolalPirelli]

Nice! IMHO it'd be easier to put it on the home page rather than create another top-level category just for this (that may also mess up mobile layout),

[SolalPirelli]

btw, github doesn't recognize "addresses" in your PR description https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword

[vinitra]

Nice! IMHO it'd be easier to put it on the home page rather than create another top-level category just for this (that may also mess up mobile layout),

I think the best solution is to add the searchbar to the header directly instead of a page, but I wasn't sure if that would mess up the formatting. I could add it to the main index page but I think it won't be found easily if you're already looking at any subpage...

Update: Discussed offline with Solal, it looks better adding it to the main page!

[basil-conto]

Looks great, thank you!

[shardulc]

What's the status on this? @vinitra do you want to address Basil's comments (and any other comments from Solal or Basil IRL since I haven't been following the conversation) before another round of review?

[SolalPirelli]

Since it works, and I want to try removing the Google dependency soon-ish, perhaps we could merge & I'll handle Basil's nits at the same time? (and if I fail to make it work without Google, I'll just put up a PR for the nits..)

[shardulc]

I'd say you should make a branch off of vini/search and make your non-Google edits there. And if the nits can be easily fixed, just push directly to vini/search and I'll take care of the merge (looks like some cleanup will be required).

[vinitra]

Taking a look now!

[vinitra]

All good from my side, thanks for the comments @basil-conto!

[shardulc]

Sorry for being a bit picky, but I think we should make this work slightly better before we merge. The table on top has poor alignment and layout. (And I think the borders shouldn’t be visible anyway, even for the search box on the front page.) Also note that the font has reverted to Arial, and the sizes are set in absolute px terms, unlike what the rest of the website uses. Not sure why the default styling makes these poor choices. But looks like the official documentation has plenty of details on how to fix this!

I’m assuming you used the PSE Control Panel for this, logging in with your personal account? Is it possible to make it with an EPIC account so it’s easier to change/maintain going forward?

[vinitra]

@shardulc it is indeed using an [email protected] account as I mentioned before (on slack!) :)

[shardulc]

Thanks again for your work on this, Vini! Superceded by #64 but Solal benefitted from your work.