-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve code documentation for MPAS dynamical core #356
base: development
Are you sure you want to change the base?
Improve code documentation for MPAS dynamical core #356
Conversation
Note to reviewers: A preview of the generated documentation can be seen here. This PR not only enables documentation generation by using Fortran Documenter (FORD), but also benefits the users of code editors with Fortran Language Server (FortLS) integration. Even if we do not use those features universally, the updated code comments are still helpful and look nice as-is. |
31a3405
to
d3a0e8c
Compare
08c2735
to
eb4a61a
Compare
@@ -1,12 +1,20 @@ | |||
! Copyright (C) 2025 U.S. National Science Foundation National Center for Atmospheric Research |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have we received specific guidance on who holds the copyright? If I recall correctly, in the past we had been advised that the copyright should be assigned to the University Corporation for Atmospheric Research.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* Better support for Fortran Documenter (FORD) * Keep code comments up-to-date
This enables us to generate documentation for MPAS dynamical core.
eb4a61a
to
9a8486e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the code comment and documentation updates @kuanchihwang!
Tag name (required for release branches):
None
Originator(s):
kuanchihwang
Descriptions (include the issue title, and the keyword ['closes', 'fixes', 'resolves'] followed by the issue number):
Improve code documentation for MPAS dynamical core.
Describe any changes made to the build system:
None
Describe any changes made to the namelist:
None
List any changes to the defaults for the input datasets (e.g., boundary datasets):
None
List all files eliminated and why:
None
List all files added and what they do:
A src/dynamics/mpas/assets/ford-config.md
List all existing files that have been modified, and describe the changes:
M src/dynamics/mpas/driver/dyn_mpas_subdriver.F90
M src/dynamics/mpas/dyn_comp.F90
M src/dynamics/mpas/dyn_coupling.F90
M src/dynamics/mpas/dyn_grid.F90
M src/dynamics/mpas/stepon.F90
Regression tests:
This is a documentation-only PR. No changes are expected to any existing tests.