part of cam6_4_075: cam_dev silhs bug fix #1016
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Katetc
reviewed
Feb 27, 2025
Katetc
approved these changes
Feb 27, 2025
There was a problem hiding this comment.
I am kind of sad about this change because we created the DDT to reduce the amount of code related to declaring all of these variables, and here it is again. I think it would be better to be able to do this within the DDT - ie, have some accessor that gives back the variable in the appropriate dimensions for subcolumn averaging. But, that would take a good bit more work than anybody has time for here, and this fixes the problem, so I'm ok with it.
cacraigucar
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #844.
This additional code in cam_dev/micro_pumas_cam.F90 will allow a run using cam_dev and SILHS, i.e. something like
to run without hitting the pcols*psubcols abort error in subcol.F90. This code is not super familiar to me, so my proposed fix (worked out with advice from @cacraigucar) may not be optimal yet, however I've tested it and it does work to get past the error and the model appears to be running normally afterward although I have not performed a months-long test yet.
Furthermore, this will not resolve a separate problem which seems more general to any subcolumns, where subcolumns print as zeros in the netcdf history files. See issue #1015 for more info about that.