Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional minor revisions to #322 #326

Merged
merged 2 commits into from
Mar 12, 2025

Conversation

slevis-lmwg
Copy link
Contributor

@slevis-lmwg slevis-lmwg commented Mar 10, 2025

Description of changes

  • mesh file needs time stamp; change the name to:
    mesh_0.5x0.5_CRUJRAv2.5mask_cdf5_c20240916.nc
  • remove /inputs directory from path to the CRUJRA data in datm/cime_config/stream_definition_datm.xml

Specific notes

Are changes expected to change answers (bfb, different to roundoff, more substantial):
No.

Testing performed (e.g. aux_cdeps, CESM prealpha, etc):
I will run aux_cdeps before this gets merged.

Sorry, something went wrong.

@slevis-lmwg
Copy link
Contributor Author

I'm starting a new round of testing for ESCOMP/CTSM#2956, which includes this aux_cdeps:
./run_sys_tests -s aux_cdeps -c /glade/campaign/cesm/cesmdata/cseg/cesm_baselines/cdeps1.0.68 -g /glade/campaign/cesm/cesmdata/cseg/cesm_baselines/cdeps1.0.70

@slevis-lmwg
Copy link
Contributor Author

slevis-lmwg commented Mar 11, 2025

aux_cdeps worked
aux_clm worked pending one test on izumi
ctsm_sci worked pending two tests
other testing worked

...so we can go ahead and review/approve/merge this PR as soon as is convenient.

@slevis-lmwg
Copy link
Contributor Author

Requesting review from @jedwards4b

@ekluzek of course you're welcome to look as well.

@jedwards4b jedwards4b merged commit 44dfda4 into ESCOMP:main Mar 12, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants