Shr log error

[jedwards4b]

Description of changes

Change of approach based on discussion in #534

Specific notes

Contributors other than yourself, if any:

CMEPS Issues Fixed (include github issue #):

Are changes expected to change answers? (specify if bfb, different at roundoff, more substantial)

Any User Interface Changes (namelist or namelist defaults changes)?

Testing performed

Please describe the tests along with the target model and machine(s)
If possible, please also added hashes that were used in the testing

[DeniseWorthen]

@jedwards4b Sorry I missed this review request. I'll try to test today or tomorrow.

[DeniseWorthen]

@uturuncoglu I'm having trouble getting this PR to pass the UFS RTs for the some of atm-lnd configurations. This is very puzzling because I can't see any reason why the lnd configurations would fail

rt_control_p8_atmlnd_debug_intel.log:Test control_p8_atmlnd_debug_intel FAIL
rt_control_p8_atmlnd_intel.log:Test control_p8_atmlnd_intel FAIL
rt_cpld_control_p8_lnd_intel.log:Test cpld_control_p8_lnd_intel FAIL

I've tested the develop branch, and they're all passing. The tests are failing completely, for example

/glade/work/worthen/ufs_cmeps/tests/logs/log_derecho/rt_cpld_control_p8_lnd_intel.log

I'm testing using a CDEPs and CMEPs branch. I can do some more debugging and let you know if I figure anything out but am I missing something?

[uturuncoglu]

@DeniseWorthen Strange. Are you merging this to NOAA-EMC CMEPS? We have some additional change in NOAA-EMC CMEPS. There are NOAA-EMC@cdbed6c and not pushed to ESCOMP. It might change the answers.

[uturuncoglu]

@DeniseWorthen As I remember, by default, samegrid_atmlnd is set to False.

[DeniseWorthen]

@uturuncoglu Actually I think I just figured it out. I think I'm missing your "same grid" fixes in my branch! I'll let you know if that doesn't fix it.

[DeniseWorthen]

@uturuncoglu Sorry for the confusion, everything is good now.

@jedwards4b This tests fine for UFS, when matched w/ CDEPS ESCOMP/CDEPS#321

[uturuncoglu]

@DeniseWorthen I am glad that it is solved in your end. BTW, may be we could also push those extra changes in the NOAA-EMC side to ESCOMP.

[DeniseWorthen]

I actually just noticed (had lost track of it...) that we still have two open PRs to push up our latest (one CMEPS, one CDEPS) for the flexible restart times. But yes, I'll get the new land-same-grid fix pushed back too.

[jedwards4b]

@DeniseWorthen Did you want to do more testing with this or can I merge?

[DeniseWorthen]

@jedwards4b No, I tracked down my failures (user error), so this is fine. Thanks.