-
Notifications
You must be signed in to change notification settings - Fork 324
megan coefs fix #3065
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
megan coefs fix #3065
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like lots of trailing white space cleanup with a few answer changing modifications. Thanks for opening up this PR.
One more question, in #3016 there was a suggestion to set A few questions / options to consider:
@tilmes, @HuiWangWanderInGitHub, @lkemmons, @rosiealice can you weigh in here? |
I think it would be great to have the soil moisture (drought) impact on MEGAN emissions be a namelist option (on/off). |
@lkemmons Do you have source mods where these changes at least hacked in? |
No, sorry, I have not implemented a namelist option.
…On Tue, Apr 15, 2025 at 4:16 PM Francis Vitt ***@***.***> wrote:
I think it would be great to have the soil moisture (drought) impact on
MEGAN emissions be a namelist option (on/off). Maybe also with the option
to provide an overall scaling factor to the new gamma_sm calculation, which
I think Rosie suggested.
@lkemmons <https://github.com/lkemmons> Do you have source mods where
these changes at least hacked in?
—
Reply to this email directly, view it on GitHub
<#3065 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AH5BH7O35PL5WSQHCXEHVID2ZWANJAVCNFSM6AAAAAB24YUFXWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDQMBXGY2TENZWHE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
*fvitt* left a comment (ESCOMP/CTSM#3065)
<#3065 (comment)>
I think it would be great to have the soil moisture (drought) impact on
MEGAN emissions be a namelist option (on/off). Maybe also with the option
to provide an overall scaling factor to the new gamma_sm calculation, which
I think Rosie suggested.
@lkemmons <https://github.com/lkemmons> Do you have source mods where
these changes at least hacked in?
—
Reply to this email directly, view it on GitHub
<#3065 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AH5BH7O35PL5WSQHCXEHVID2ZWANJAVCNFSM6AAAAAB24YUFXWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDQMBXGY2TENZWHE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
I was referring to changes to the code for "the soil moisture (drought) impact on MEGAN emissions" and "overall scaling factor to the new gamma_sm calculation" |
The new code for gamma_sm is already in. We want to include the option to
have that be =1, or use the new calculation.
An overall scale factor would also have to be added.
…On Tue, Apr 15, 2025 at 4:36 PM Francis Vitt ***@***.***> wrote:
No, sorry, I have not implemented a namelist option.
I was referring to changes to the code for "the soil moisture (drought)
impact on MEGAN emissions" and "overall scaling factor to the new gamma_sm
calculation"
—
Reply to this email directly, view it on GitHub
<#3065 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AH5BH7LRAZV5NEQU24RKKWD2ZWCWXAVCNFSM6AAAAAB24YUFXWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDQMBXGY4DIMZYGA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
*fvitt* left a comment (ESCOMP/CTSM#3065)
<#3065 (comment)>
No, sorry, I have not implemented a namelist option.
I was referring to changes to the code for "the soil moisture (drought)
impact on MEGAN emissions" and "overall scaling factor to the new gamma_sm
calculation"
—
Reply to this email directly, view it on GitHub
<#3065 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AH5BH7LRAZV5NEQU24RKKWD2ZWCWXAVCNFSM6AAAAAB24YUFXWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDQMBXGY4DIMZYGA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
As @HuiWangWanderInGitHub noted in #3016 around line 568 in clm/src/biogeochem/VOCEmissionMod.F90
where use_megan_gamma_sm is a namelist parameter. I'm less confident in how to apply the idea of
If we add a modifier into gamma_sm I suggest it go on the CLM parameter file.my hacky python code for this example is below:
Hope this helps. |
I guess if we like the used of
|
Description of changes
Corrections on how MEGAN coefficients are applied.
Depends on ESCOMP/CMEPS#557
Specific notes
Contributors other than yourself, if any:
CTSM Issues Fixed (include github issue #):
Fixes #3016
Are answers expected to change (and if so in what way)? Yes, for MEGAN fields
Any User Interface Changes (namelist or namelist defaults changes)? No
Does this create a need to change or add documentation? Did you do so? No
Testing performed, if any: scientific testing is underway