-
Notifications
You must be signed in to change notification settings - Fork 324
fix some st_archive issues with rpointer files #3067
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: b4b-dev
Are you sure you want to change the base?
Conversation
Thanks for making this PR @jedwards4b we'll discuss at our weekly meeting. |
Because this includes submodule updates, this will likely need to follow some other PR's with submodule updates. And the tags for submodules will all need to be done before merging. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is straightforward and makes sense to me.
I rebased this to b4b-dev, and maybe the way to do this one, would be to bring this one as it is, and then do the other submodule updates in a different PR. They don't have to be connected together, although they all need to come together in a final tag to get the benefits. |
@ekluzek will merge this to b4bdev and create issues for the definition of done wrt other components |
Description of changes
Fix some issues related to timestamp rpointer files not being archived correctly.
Specific notes
Contributors other than yourself, if any: Mike Levy
CTSM Issues Fixed (include github issue #):
Are answers expected to change (and if so in what way)? NO
Any User Interface Changes (namelist or namelist defaults changes)? No
Does this create a need to change or add documentation? Did you do so? No
Testing performed, if any: will run regular and ctsm_sci
Tested archiving of fully coupled cases with DOUT_S_SAVE_INTERIM_RESTART_FILES: FALSE and
DOUT_S_SAVE_INTERIM_RESTART_FILES: TRUE
Definition of done: