Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfix/366_ api signup page issue #167

Merged
merged 1 commit into from
Dec 18, 2023
Merged

bugfix/366_ api signup page issue #167

merged 1 commit into from
Dec 18, 2023

Conversation

cschwinderg
Copy link
Collaborator

Related Issues:

Main Changes:

  • Fixed issue where the api signup page was crashing. I tracked the issue down to a conditionally rendered loading spinner being inside the div for the api.data.gov form. I'm not entirely sure why we didn't see this error before. I suspect the recaptcha library (imported by api.data.gov form) was updated and caused the issue.

Steps To Test:

  1. Navigate to http://localhost:3000/api-key-signup
  2. Verify the signup page loads

@cschwinderg cschwinderg changed the title EQ-366 Fixed issue of the api signup page crashing. bugfix/366_ api signup page issue Dec 18, 2023
@cschwinderg cschwinderg merged commit 3b6ecc2 into develop Dec 18, 2023
1 check passed
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@cschwinderg cschwinderg deleted the bugfix/366_api-signup-page-issue branch December 21, 2023 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@cschwinderg