Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/458 document search tests #199

Merged
merged 9 commits into from
Jan 10, 2025

Conversation

maxdiebold-erg
Copy link
Collaborator

Related Issues:

Main Changes:

  • Added several tests for the new document text search functionality.
  • Fixed failing tests.
    • One test was failing because searching in a select filter box was not filtering the "default" options, just the options returned from the database.

Copy link
Collaborator

@cschwinderg cschwinderg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All tests passed! Also, coverage is still above 80%!

I noticed a it.only in one of the tests, so I pushed up a commit to remove that.

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@cschwinderg cschwinderg merged commit 097b367 into develop Jan 10, 2025
5 of 6 checks passed
@cschwinderg cschwinderg deleted the feature/458_document-search-tests branch January 10, 2025 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants