Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EQ-442 Updated 3rd party dependencies #200

Merged
merged 4 commits into from
Jan 10, 2025

Conversation

maxdiebold-erg
Copy link
Collaborator

Related Issues:

Main Changes:

  • Updated project dependencies where possible. I left React at v18 for now.

Steps To Test:

  1. Test as much of the App and ETL as possible. At the time of writing, several of the profiles are inaccessible via Ordspub, so you will need to skip loading those profiles if you want to run the ETL, i.e. starting at line 749 of etl/app/server/database.js:
    // Add tables to schema and import new data
    const loadTasks = Object.values(s3Config.tableConfig)
      .filter((profile) => profile.source?.toLowerCase() === 'attains')
      .filter(
        (profile) =>
          ![
            'sources',
            'assessments',
            'assessmentUnits',
            'assessmentUnitsMonitoringLocations',
          ].includes(profile.id),
      )
      .map((profile) => {
        return loadProfile(profile, pool, schemaName, s3Config, s3Julian);
      });
    await Promise.all(loadTasks);

    // Create views and materialized views.
    await Promise.all(
      Object.values(s3Config.tableConfig)
        .filter(
          (profile) =>
            ![
              'sources',
              'assessments',
              'assessmentUnits',
              'assessmentUnitsMonitoringLocations',
            ].includes(profile.id),
        )
        .map(async (profile) => {
          await createProfileMaterializedViews(pool, schemaName, profile);
          await createProfileViews(pool, schemaName, profile);
        }),
    );

Copy link

socket-security bot commented Jan 10, 2025

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@aws-sdk/[email protected] Transitive: environment, filesystem +93 8.2 MB amzn-oss, aws-sdk-bot, kuhe, ...2 more
npm/@reach/[email protected] environment +20 1 MB chancestrickland
npm/@types/[email protected] Transitive: environment, filesystem, unsafe +41 1.67 MB types
npm/@types/[email protected] None 0 868 kB types
npm/@types/[email protected] None +1 2.3 MB types
npm/@types/[email protected] None 0 37.9 kB types
npm/@types/[email protected] None 0 25.8 kB types
npm/@types/[email protected] None +2 1.69 MB types
npm/@types/[email protected] None 0 6.17 kB types
npm/@typescript-eslint/[email protected] Transitive: environment, filesystem +37 7.86 MB bradzacher, jameshenry
npm/@typescript-eslint/[email protected] Transitive: environment, filesystem +29 2.92 MB bradzacher, jameshenry
npm/@uswds/[email protected] Transitive: environment, filesystem, network, shell, unsafe +274 357 MB thisisdano
npm/@uswds/[email protected] None +6 18.3 MB thisisdano
npm/@vitejs/[email protected] Transitive: environment, filesystem, unsafe +47 11.6 MB vitebot
npm/[email protected] None 0 9.67 MB xhmikosr
npm/[email protected] None 0 23.6 kB jedwatson
npm/[email protected] environment 0 169 kB react-bot
npm/[email protected] None 0 18.2 kB arnaud-barre
npm/[email protected] environment Transitive: eval, filesystem, shell, unsafe +83 10.6 MB eslintbot
npm/[email protected] environment +3 4.63 MB react-bot
npm/[email protected] Transitive: environment +79 2.61 MB wooorm
npm/[email protected] None +5 2.4 MB chancestrickland, mjackson, timdorr
npm/[email protected] None +7 677 kB vtaits
npm/[email protected] environment Transitive: filesystem, unsafe +71 11.8 MB react-select-release-bot
npm/[email protected] None +2 1.17 MB brianvaughn
npm/[email protected] environment +2 339 kB react-bot
npm/[email protected] None 0 27.9 kB benjamn
npm/[email protected] Transitive: environment +67 2.34 MB wooorm
npm/[email protected] Transitive: environment, eval, filesystem, network, shell +147 102 MB swagger-api
npm/[email protected] None 0 22.7 MB andrewbranch, minestarks, rbuckton, ...5 more
npm/[email protected] environment Transitive: eval, filesystem, network, unsafe +71 13.4 MB ifaxity
npm/[email protected] filesystem Transitive: environment, unsafe +97 62.7 MB pd4d10
npm/[email protected] environment, filesystem +4 202 kB aleclarson
npm/[email protected] Transitive: environment, filesystem, shell, unsafe +79 618 MB antfu, patak, soda, ...2 more

🚮 Removed packages: npm/@aws-sdk/[email protected], npm/@cypress/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected]

View full report↗︎

Copy link
Collaborator

@cschwinderg cschwinderg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

I updated another app to react 19 and it was actually pretty easy. I'm ok with pushing react 19 and node 22 to the next deployment, since we don't have much time to test.

@cschwinderg cschwinderg merged commit f11b825 into develop Jan 10, 2025
7 checks passed
@cschwinderg cschwinderg deleted the feature/442_update-dependencies branch January 10, 2025 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants