Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/duplicate rows #207

Merged
merged 2 commits into from
Jan 13, 2025
Merged

Bugfix/duplicate rows #207

merged 2 commits into from
Jan 13, 2025

Conversation

maxdiebold-erg
Copy link
Collaborator

@maxdiebold-erg maxdiebold-erg commented Jan 13, 2025

Related Issues:

Main Changes:

  • Remove duplicate rows when querying the documents view without a text query. This removal is already in place when querying with a text query.

Steps To Test:

  1. Go to http://localhost:3000/attains/actionDocuments?documentName=Sweitzers%20Run%20Phosphorus%20TMDL&documentName=Sweitzers%20Run%20Sediment%20TMDL&documentName=SweitzersRun_Approval. Select Preview or Download. Confirm there are only 6 rows of results (there were previously 12). NOTE: There may still appear to be duplicate rows in the preview modal; this is because there are separate rows for different document types (actionDocumentType). We may want to add this field to the preview window, but this is a relatively rare occurrence.

Copy link
Collaborator

@cschwinderg cschwinderg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@cschwinderg cschwinderg merged commit a4b6ae9 into develop Jan 13, 2025
7 checks passed
@cschwinderg cschwinderg deleted the bugfix/duplicate-rows branch January 13, 2025 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants