Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/640 source menu close on click #918

Merged
merged 2 commits into from
Dec 21, 2023

Conversation

maxdiebold-erg
Copy link
Collaborator

Related Issues:

Main Changes:

  • Added a blur handler to the outermost containers around the "source" selection menus, used in the LocationSearch component and on the State & Tribal page, which closes the menu when clicked or tabbed outside.
    • I started to refactor the select menu into its own component, like in Expert Query, but the location search menu is dug in pretty deep. I figured that could be saved for refactoring during "the re-write", or even just a separate PR.

Steps To Test:

  1. Go to the home page, open the source menu of the search input, then click outside the menu. Confirm the menu closes.
  2. Open the source menu, then press the Tab key, and confirm the menu closes.
  3. Verify that it is still possible to select an item from the source menu, using either the mouse or the Enter key.
  4. Repeat steps 1-3 for the search inputs on the Community and State & Tribal pages.

Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Collaborator

@cschwinderg cschwinderg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@cschwinderg cschwinderg merged commit 9a9ed37 into develop Dec 21, 2023
3 checks passed
@cschwinderg cschwinderg deleted the bugfix/640_source-menu-close-on-click branch December 21, 2023 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants