Improved /etc/hosts management to support EasyEngine deployment in Containers #443
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Detailed Description:
This PR addresses the issue of EasyEngine being unable to reliably manage the host's
/etc/hosts
file when deployed in a container, which hinders the use of EasyEngine in virtualized environments.-> Easyengine on Container
Problem:
The
remove_etc_hosts_entry
function insrc/helper/site-utils.php
currently usesFilesystem()->dumpFile()
. This method is incompatible or has permission limitations when the container attempts to modify the host's/etc/hosts
via a volume mount.Solution:
The
remove_etc_hosts_entry
function has been refactored to use PHP's nativefile_get_contents
andfile_put_contents
methods. Improvements include:LOCK_EX
for atomic write operations.stream_context_create
with'file' => ['privileged' => true]
for permission handling.preg_quote
to escape special characters in the URL.Benefits:
/etc/hosts
management.Testing:
Successfully tested in a Docker container environment and directly on the host machine.