Flags: Do not hardcode one Flag field per class #492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was hardcoded to one Flag per struct. The generator is now smarter and you can specify multiple flags which are resolved by their flag name.
…ify which enum names are considered to be "scoped" ('class' enums in C++)
… determine if an event has been created by EasyRPGs new "CloneMapEvent" command
fdelapena
approved these changes
Mar 1, 2025
|
@florianessl this should be okay now? |
florianessl
approved these changes
Mar 8, 2025
florianessl
reviewed
Mar 8, 2025
…preter related SaveState structures (SaveEventExecState, SaveEventExecFrame & SaveMapEventBase) Co-Authored-By: florianessl <[email protected]>
florianessl
reviewed
Mar 8, 2025
| std::array<bool, 20> flags; | ||
| }; | ||
| EasyRpgStateRuntime_Flags() noexcept | ||
| {} |
There was a problem hiding this comment.
Oh, another thing. Sorry for missing that when I first reviewed this:
These flag structures don't seem to be properly initialized. So whenever a flag field is accessed on a newly created SaveEventExecState, there is just garbage data here. :/
Maybe just append a line in the constructor here?
flags.fill(false);
There was a problem hiding this comment.
Hu. I think you found a general bug applicable to all flags 😅.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an alternative approach for #491
Instead of a single variable it uses our Flag feature to provide bool variables. This reduces the need for bitmasking.
Problem was that our code always hardcoded
StructName_Flagsfor Flags. This restriction is now lifted and multiple Structs can have the same flags and a struct can have multiple flags.Don't merge, Player build failure because classes are renamed