Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Flysky Noble 4 Plus (NB4+) support #5095

Open
wants to merge 32 commits into
base: main
Choose a base branch
from
Open

feat: Flysky Noble 4 Plus (NB4+) support #5095

wants to merge 32 commits into from

Conversation

richardclli
Copy link
Collaborator

@richardclli richardclli commented Jun 1, 2024

Flysky Noble 4 Plus (NB4+) Support

Development progress:

  • LCD drver
  • touch driver
  • ST, TH
  • pots
  • switches
  • trims
  • encoder (the hardware has 2 encoders, once mapped one currently, need some input to how to make use 2nd encoder)
  • audio
  • battery charging
  • internal module (STM32F030 MCU nothing good can be supported)
  • external module (Bluetooth USART3 port, mapped as internal module that can support MULTI/AFHDS3/CRSF)
  • modding documentation https://github.com/EdgeTX/edgetx/wiki/Flysky-NB4--Hardware-Mod-for-Complete-EdgeTX-Support

Known hardware limitations:

  1. No on board RTC support, missing battery and a few cap, diode, crystal components. (PL18 is a lot simpler, just need to add a battery)
  2. NOR flash is small (Only 8MB on board, can change the chip to maximum 128MB, same as PL18 mod)
  3. DAC sound output work out of the box without modding ^.^

@richardclli richardclli added this to the 2.11 milestone Jun 1, 2024
@richardclli richardclli changed the title feat(nb4p): Flysky Noble 4 Plus Support feat(nb4p): Flysky Noble 4 Plus (NB4+) Support Jun 1, 2024
@richardclli richardclli self-assigned this Jun 1, 2024
@pfeerick pfeerick changed the title feat(nb4p): Flysky Noble 4 Plus (NB4+) Support feat: Flysky Noble 4 Plus (NB4+) support Jun 1, 2024
@richardclli richardclli force-pushed the fs_nb4plus branch 2 times, most recently from c007856 to d307b41 Compare June 8, 2024 20:48
@richardclli richardclli force-pushed the fs_nb4plus branch 2 times, most recently from d5b505a to 6779428 Compare June 16, 2024 02:47
@richardclli richardclli force-pushed the fs_nb4plus branch 2 times, most recently from c966618 to c952b8b Compare June 28, 2024 04:36
@richardclli richardclli force-pushed the fs_nb4plus branch 4 times, most recently from 330b500 to 7ae769f Compare July 7, 2024 09:58
@richardclli richardclli force-pushed the fs_nb4plus branch 8 times, most recently from 8bfe593 to 0096da0 Compare July 19, 2024 02:01
@richardclli richardclli force-pushed the fs_nb4plus branch 6 times, most recently from 6f96397 to e1bbc88 Compare July 29, 2024 03:51
@richardclli
Copy link
Collaborator Author

richardclli commented Nov 30, 2024

Finally walked through all code generation dependencies. Need the naming of switches matched to have proper switch config generated and the test cannot pass without proper switch config. And one test case failed because it required more than 2 switches and in which nb4p did not have that much in current implementation.

Haha, some tests harcoded the switch names to SA, SB, etc. So..... the other way round.......

@richardclli
Copy link
Collaborator Author

@pfeerick @raphaelcoeffic Please review to see if you have any concerns on the changes in code generation scripts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants