fix(sim): workaround for settings being retained when restarting the simulator. #5931
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philmoz
added
bug 🪲
philmoz
force-pushed
the
philmoz/sim-start-workaround
branch
from
de48396 to
33ec0ea
Compare
|
@philmoz actually, this change is going backwards. These fields have been moved out of the huge RadioData structure as they are not required for EM, and it makes it much less dependent on generated code. I think we should keep it that way. |
|
They are marked as NOBACKUP so are not saved in RTC memory. IMO these belong in radio data. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Workaround for #5919
Underlying reason is still to be determined; but this workaround resolves the issue for now.