Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cpn): don't assume all lcd customisable switches have colour settings #5950

Merged
merged 1 commit into from
Feb 27, 2025
Merged

fix(cpn): don't assume all lcd customisable switches have colour settings #5950

merged 1 commit into from
Feb 27, 2025
+10 −6

Conversation

elecpower
Copy link
Collaborator

Summary of changes:

  • do not assume led on/off colour settings are present for every possible function switch

@elecpower elecpower added bug 🪲 Something isn't working companion Related to the companion software labels Feb 26, 2025
@elecpower elecpower added this to the 2.11 milestone Feb 26, 2025
@elecpower elecpower mentioned this pull request Feb 25, 2025
Closed
@pfeerick pfeerick changed the title fix(cpn): read model function switch colour settings fix(cpn): don't assume all customisable switch colour settings are set Feb 27, 2025
@pfeerick pfeerick changed the title fix(cpn): don't assume all customisable switch colour settings are set fix(cpn): don't assume all lcd customisable switches have colour settings Feb 27, 2025
@pfeerick pfeerick merged commit a220ea3 into main Feb 27, 2025
3 checks passed
@pfeerick pfeerick deleted the elecpower/cpn-fix-mdl-yaml-decode branch February 27, 2025 23:16
@pfeerick
Copy link
Member

Thanks, works with that GX12 problem model :)

pfeerick pushed a commit that referenced this pull request Feb 27, 2025
@elecpower @pfeerick
fix(cpn): don't assume all lcd customisable switches have colour sett…
4827fb7 
…ings (#5950)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug 🪲 Something isn't working companion Related to the companion software
Projects
None yet
Milestone
2.11
Development

Successfully merging this pull request may close these issues.
2 participants
@elecpower @pfeerick