Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare for Simplified Chinese support #776

Merged
merged 3 commits into from
Sep 10, 2023
Merged

Prepare for Simplified Chinese support #776

merged 3 commits into from
Sep 10, 2023

Conversation

lupino3
Copy link
Member

@lupino3 lupino3 commented Sep 10, 2023

These changes should make merging #772 possible, by using logical font names and specifying the encoding of source files.

This also fixes the names of some test methods that were triggering Codacy errors.

This is necessary to properly read source files with non-ASCII
characters.
This should allow the runtime to choose the most appropriate font within
the given family.
The method naming convention for Java suggests not to use underscores.
@codecov-commenter
Copy link

Codecov Report

Merging #776 (9ead5ef) into master (9cdb265) will not change coverage.
Report is 1 commits behind head on master.
The diff coverage is 0.00%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #776   +/-   ##
=========================================
  Coverage     51.14%   51.14%           
  Complexity     1447     1447           
=========================================
  Files           249      249           
  Lines          9879     9879           
  Branches       1092     1092           
=========================================
  Hits           5053     5053           
  Misses         4507     4507           
  Partials        319      319           
Files Changed Coverage Δ
.../main/java/org/edumips64/ui/swing/ErrorDialog.java 0.00% <0.00%> (ø)
src/main/java/org/edumips64/ui/swing/GUIAbout.java 0.00% <0.00%> (ø)
...rc/main/java/org/edumips64/ui/swing/GUICycles.java 0.00% <0.00%> (ø)
.../main/java/org/edumips64/ui/swing/GUIPipeline.java 0.00% <0.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9cdb265...9ead5ef. Read the comment docs.

@github-actions github-actions bot temporarily deployed to 776 September 10, 2023 07:12 Destroyed
@lupino3 lupino3 merged commit 2135c87 into master Sep 10, 2023
@lupino3 lupino3 deleted the prepare-for-chinese branch September 10, 2023 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants