Skip to content

Removed some unnecessary single-arg pipe calls #5211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 14, 2025

Conversation

mattiamanzati
Copy link
Contributor

Description

Cleaned up some single-arg pipe calls.

Copy link

changeset-bot bot commented Jul 14, 2025

🦋 Changeset detected

Latest commit: ed98ffc

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 35 packages
Name Type
@effect/experimental Patch
@effect/sql-drizzle Patch
@effect/platform Patch
@effect/cluster Patch
effect Patch
@effect/sql Patch
@effect/sql-clickhouse Patch
@effect/sql-d1 Patch
@effect/sql-libsql Patch
@effect/sql-mssql Patch
@effect/sql-mysql2 Patch
@effect/sql-pg Patch
@effect/sql-sqlite-bun Patch
@effect/sql-sqlite-do Patch
@effect/sql-sqlite-node Patch
@effect/sql-sqlite-react-native Patch
@effect/sql-sqlite-wasm Patch
@effect/ai Patch
@effect/ai-amazon-bedrock Patch
@effect/ai-anthropic Patch
@effect/ai-google Patch
@effect/ai-openai Patch
@effect/cli Patch
@effect/opentelemetry Patch
@effect/platform-browser Patch
@effect/platform-bun Patch
@effect/platform-node-shared Patch
@effect/platform-node Patch
@effect/rpc Patch
@effect/workflow Patch
@effect/printer-ansi Patch
@effect/printer Patch
@effect/sql-kysely Patch
@effect/typeclass Patch
@effect/vitest Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@@ -103,7 +103,7 @@ describe.concurrent("Sharding", () => {
}, 0)
}).pipe(
Effect.provide(TestShardingWithoutRunners.pipe(
Layer.provide(Layer.effect(
Layer.provide(Layer.scoped(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was it leaking a scope?

Copy link
Contributor Author

@mattiamanzati mattiamanzati Jul 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup it was, got catched by the LSP

@tim-smart tim-smart merged commit d25f22b into main Jul 14, 2025
11 checks passed
@tim-smart tim-smart deleted the cleanup-single-arg-pipes branch July 14, 2025 21:01
@github-project-automation github-project-automation bot moved this from Discussion Ongoing to Done in PR Backlog Jul 14, 2025
@github-actions github-actions bot mentioned this pull request Jul 14, 2025
nikelborm pushed a commit to nikelborm/effect that referenced this pull request Jul 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants