-
Notifications
You must be signed in to change notification settings - Fork 942
lq: Add taproot channel support for elements #8097
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
cdecker
wants to merge
4
commits into
ElementsProject:master
Choose a base branch
from
cdecker:202448-elements-anchors
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d26af91
to
eb9a691
Compare
Following the upgrade of My current status is the following:
I found the following so far:
Backtrace:
|
eb9a691
to
5ba3c38
Compare
Changelog-Changed: liquid: Added support for anchor outputs for liquid channels
The fee output is mandatory in `elements`-based chains, for the homomorphic amount commitment to work out. These transactions were missing that output.
5ba3c38
to
1557918
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
libwally
did not support signing taproot outputs untilrecently. This means that on
elements
-based networks we woulddefault to the legacy non-taproot channels.
Since
libwally
recently gained support for signing taproot outputswe can remove support for legacy channels altogether now. This is also
a requirement to work with the VLS signer, which no longer supports
legacy channels either.
Depends-On: #8098 #8158