Skip to content

bcli: don't try asking non-full nodes for blocks. #8268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rustyrussell
Copy link
Contributor

Suggested-by: @NicolasDorier
Closes: #8078

Changelog-Changed: Protocol: we no longer try asking for blocks from bitcoind's peers if they don't store blocks.
\

@rustyrussell rustyrussell added this to the v25.05 milestone May 6, 2025
@rustyrussell rustyrussell requested a review from nepet May 6, 2025 04:51
Suggested-by: @NicolasDorier
Closes: ElementsProject#8078
Signed-off-by: Rusty Russell <[email protected]>
Changelog-Changed: Protocol: we no longer try asking for blocks from bitcoind's peers if they don't store blocks.
@rustyrussell rustyrussell force-pushed the getblocks-only-full-nodes branch from 2c9d640 to b61141e Compare May 6, 2025 05:09
Copy link
Collaborator

@nepet nepet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this!

Ack b61141e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bcli: Filter for full nodes on getpeerinfo
2 participants