Bug fix for rdairplay 'Select Log' window showing stale data.

[cconkrig]

Description

Bug Fix: rdairplay's "Select Log" window contained stale data unless service or limit was changed or rdairplay was restarted. Removed the condition check in RDLogListModel::setFilterSql to ensure the model is always updated when setFilterSql is called. Added code to clear the selection (previously selected line before window was closed) in the log view. Added code to reset the vertical scroll bar to the top position when the log list is refreshed. These items effectively reset the dialog window to the initial state when rdairplay is started.

Fixes Issue #984

Type of change

Please delete options that are not relevant.

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

How Has This Been Tested?

Manual compilation of source, ran the program and verified manually that the change was effective in rdairplay. I even manually added a log, closed the window, left rdairplay running, modified the name of the log in database backend, opened the select log window again, and everything appears to be updated and in the correct sort order as if you relaunched rdairplay. This was tested multiple times with success.

Checklist:

• My code follows the style guidelines of this project
• I have performed a self-review of my code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes
• Any dependent changes have been merged and published in downstream modules

[cconkrig]

@ElvishArtisan this one should be pretty straight forward too. I could not find a reason for needing to check the state of the filter. You are calling it to update during load but subsequent loads do not fire the update method unless that conditional check is removed. I didn't see any reason this would cause a problem elsewhere. If I am not submitting these the correct way, please let me know. I'll try to help where I can.