Skip to content

v1.0.0 #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 18, 2025
Merged

v1.0.0 #67

merged 2 commits into from
Apr 18, 2025

Conversation

osipxd
Copy link
Member

@osipxd osipxd commented Apr 17, 2025

Pivot!

After a 4-year hiatus in releases, the plugin landscape has evolved significantly.
jpenilla's excellent plugins run-task and resource-factory have been released,
and they're perfect for running Paper servers and generating plugin.yml.

Rather than maintaining our own implementations, BukkitGradle now leverages jpenilla's work, allowing us to:

  1. Reduce maintenance burden: By delegating core functionality to actively maintained projects
  2. Focus on innovation: Instead of reinventing the wheel, we can add new features

The main goal of BukkitGradle is now to provide nice defaults and a unified API
that simplifies plugin development by seamlessly integrating these plugins.

Features

  • Breaking change!
    Use jpenilla/run-task plugin and integrate run-paper for server execution,
    improving maintainability and compatibility with various server versions.
    • Remove bukkit.server.coreType property.
      Spigot is not supported anymore, PaperMC is the only supported server.
      If you need to run other server cores,
      please file an issue.
  • Breaking change!
    Use jpenilla/resource-factory under the hood to generate plugin.yml.
    This change enables full configuration of plugin.yml from a build script, but it comes with some renaming:
    • Configuration block bukkit.meta { ... } -> bukkit.plugin { ... }
    • Property bukkit.plugin.url -> bukkit.plugin.website
    • Task :parsePluginMetaFile -> :parsePluginYaml
    • Task :mergePluginMeta has been dropped. Use :mainResourceFactory instead
    • Package ru.endlesscode.bukkitgradle.meta -> ru.endlesscode.bukkitgradle.plugin
  • Breaking change! Don't add repositories implicitly.
    It was impossible to opt out from automatic repositories adding.
    From now, repositories should be added manually. For example:
    repositories {
        mavenCentral()
        papermc()
    }
  • Breaking change!
    Don't set default bukkit.apiVersion.
    It was implicitly set to 1.16.4 for the sake of simplicity, but in fact it was unobvious behavior.
    Now, bukkit.apiVersion should be set explicitly:
    bukkit {
        apiVersion = "1.20.5"
    }
  • Support setting "api-version" containing a patch version for v1.20.5+
  • Add dependency substitution rules fixing paper groupId and substituting bukkit version.
    In version catalogs placeholder value {bukkit.version} can be used, and it will be replaced with the actual version:
    [libraries]
    paperApi = { module = "io.papermc.paper:paper-api", version = "{bukkit.apiVersion}" }
  • Set the default JVM toolchain version
    instead of setting JVM target and source compatibility to 1.8.
    By default, the minimal supported JVM version compatible with the specified bukkit.apiVersion is used.
  • Accept EULA using CLI parameter -Dcom.mojang.eula.agree=true instead of changing eula.txt

Changed

  • Change the default value of bukkit.server.debug to false.
    It is recommended to use IDE facilities to run server with enabled debugging.
  • Change API for disabling plugin.yml generation:
    -bukkit.disableMetaGeneration()
    +bukkit.generatePluginYaml.set(false)
  • Use lazy API for bukkit.apiVersion property.

Fixed

  • Fix PaperMC repository URL
  • Fix group ID for PaperMC 1.17+
  • Fix compatibility with new versions of Shadow plugin

Housekeeping

  • Target JVM 1.8 → 17
  • Gradle 7.2 → 8.13
  • Remove old deprecated APIs

@osipxd osipxd self-assigned this Apr 17, 2025
Copy link

coderabbitai bot commented Apr 17, 2025

Walkthrough

This update marks the release of version 1.0.0 after a significant gap, introducing major changes to the project's structure and APIs. Core functionalities for running Paper servers and generating plugin.yml are now delegated to external plugins, removing internal implementations and dropping support for Spigot in favor of PaperMC only. Several configuration blocks, properties, and tasks are renamed or removed, and the plugin's API is streamlined. The default JVM toolchain version is now dynamically set based on the specified bukkit.apiVersion. Documentation and project metadata are updated to reflect these changes.

Changes

File(s) Change Summary
CHANGELOG.md Documents the 1.0.0 release, detailing major architectural changes, API renames, removals, and updated configuration.
README.md Updates version references, example code, and feature list to reflect new APIs and the 1.0.0 release.
gradle.properties Updates project description and increments version from 0.11.0-SNAPSHOT to 1.0.0.

Sequence Diagram(s)

sequenceDiagram
    participant Developer
    participant BukkitGradle
    participant run-task Plugin
    participant resource-factory Plugin
    participant Paper Server

    Developer->>BukkitGradle: Configure build (set bukkit.apiVersion, etc.)
    BukkitGradle->>run-task Plugin: Delegate server running tasks
    BukkitGradle->>resource-factory Plugin: Delegate plugin.yml generation
    run-task Plugin->>Paper Server: Start server with specified configuration
    resource-factory Plugin->>BukkitGradle: Provide generated plugin.yml
Loading

Possibly related PRs

  • Remove old deprecated APIs #65: Removes deprecated methods and properties from BukkitExtension and PluginConfigurationImpl, closely related to the current PR's removal and renaming of API elements and properties.

Poem

Hopping forward, version one,
Old code’s gone, the cleanup’s done!
Paper’s the path, Spigot’s past,
Plugin blocks renamed at last.
External helpers join the play,
A bunny builds in a modern way!
🐇✨


🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 53ec8ec and 8cdfc32.

📒 Files selected for processing (3)
  • CHANGELOG.md (5 hunks)
  • README.md (4 hunks)
  • gradle.properties (1 hunks)
✅ Files skipped from review due to trivial changes (1)
  • README.md
🚧 Files skipped from review as they are similar to previous changes (1)
  • gradle.properties
🧰 Additional context used
🧠 Learnings (1)
CHANGELOG.md (2)
Learnt from: osipxd
PR: EndlessCodeGroup/BukkitGradle#66
File: README.md:104-108
Timestamp: 2025-04-17T20:35:24.623Z
Learning: In Bukkit plugin.yml, the `api-version` field doesn't support patch versions for Minecraft versions lower than 1.20.5. Even if `apiVersion = "1.16.5"` is specified in configuration, it will be transformed to `api-version: '1.16'` in the generated plugin.yml file. Starting from Minecraft 1.20.5, full patch versions are supported in the api-version field.
Learnt from: osipxd
PR: EndlessCodeGroup/BukkitGradle#66
File: README.md:104-108
Timestamp: 2025-04-17T20:35:24.623Z
Learning: In Bukkit plugin.yml, the `api-version` field doesn't support patch versions for Minecraft versions lower than 1.20.5. Even if `apiVersion = "1.16.5"` is specified in configuration, it will be transformed to `api-version: '1.16'` in the generated plugin.yml file. Starting from Minecraft 1.20.5, full patch versions are supported in the api-version field.
🪛 LanguageTool
CHANGELOG.md

[uncategorized] ~58-~58: Possible missing comma found.
Context: ...bstituting bukkit version. In version catalogs placeholder value {bukkit.version} ca...

(AI_HYDRA_LEO_MISSING_COMMA)

⏰ Context from checks skipped due to timeout of 90000ms (1)
  • GitHub Check: Check
🔇 Additional comments (13)
CHANGELOG.md (13)

3-3: Keep the Unreleased placeholder as-is.
The *No changes yet* entry clarifies that no upcoming changes are documented yet.


5-5: Release header is correctly formatted.
The version 1.0.0 and date 2025-04-18 follow the established convention.


7-7: Pivot section title is clear.
The ### Pivot! heading effectively highlights the major shift in project direction.


9-11: Introduction paragraphs are concise and informative.
They succinctly explain why jpenilla’s plugins were chosen and set the context for the pivot.


13-16: Bullet list clearly states the goals.
The points “Reduce maintenance burden” and “Focus on innovation” are well articulated.


18-19: Main goal description is on point.
It reinforces the purpose of the unified API and nice defaults.


21-21: Features section heading is in place.
This anchors the forthcoming list of enhancements and breaking changes.


24-24: Run-task integration description is clear.
Specifying the removal of bukkit.server.coreType and spigot drop is well documented.


31-32: Resource-factory integration is well explained.
You’ve clearly listed renames and the migration from mergePluginMeta to mainResourceFactory.


65-65: Default JVM toolchain note is precise.
Clearly indicates replacing source/target compatibility with the toolchain strategy.


72-77: Plugin YAML generation API change is well documented.
The diff block clearly shows the migration from disableMetaGeneration() to the lazy setter.


87-88: Housekeeping upgrades are accurately listed.
Target JVM bump and Gradle upgrade align with the project’s new baseline.


218-219: Footer links are correctly linked.
The compare URLs for [unreleased] and [1.0.0] follow the expected pattern.

@osipxd osipxd merged commit c5899d2 into develop Apr 18, 2025
3 checks passed
@osipxd osipxd deleted the v1.0.0 branch April 18, 2025 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant