-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hint compiler to not specialize compile
methods
#144
Open
mofeing
wants to merge
1
commit into
main
Choose a base branch
from
ss/nospecialize-comptime-optimizations
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reactant.jl Benchmarks
Benchmark suite | Current: 222625f | Previous: 4f4cb40 | Ratio |
---|---|---|---|
ViT base (256 x 256 x 3 x 32)/forward/CUDA/Reactant |
1318940641 ns |
1427801876 ns |
0.92 |
ViT base (256 x 256 x 3 x 32)/forward/CUDA/Lux |
232704274 ns |
241937991 ns |
0.96 |
ViT base (256 x 256 x 3 x 32)/forward/CPU/Reactant |
5297983590 ns |
5706546145 ns |
0.93 |
ViT base (256 x 256 x 3 x 32)/forward/CPU/Lux |
27391225052 ns |
19592540088 ns |
1.40 |
ViT small (256 x 256 x 3 x 4)/forward/CUDA/Reactant |
1291926315.5 ns |
1367040220.5 ns |
0.95 |
ViT small (256 x 256 x 3 x 4)/forward/CUDA/Lux |
8101212 ns |
8765018 ns |
0.92 |
ViT small (256 x 256 x 3 x 4)/forward/CPU/Reactant |
1625149502 ns |
1617045921.5 ns |
1.01 |
ViT small (256 x 256 x 3 x 4)/forward/CPU/Lux |
2291206144 ns |
2228339749.5 ns |
1.03 |
ViT tiny (256 x 256 x 3 x 32)/forward/CUDA/Reactant |
1334446605.5 ns |
1369778487.5 ns |
0.97 |
ViT tiny (256 x 256 x 3 x 32)/forward/CUDA/Lux |
93860961 ns |
95384074 ns |
0.98 |
ViT tiny (256 x 256 x 3 x 32)/forward/CPU/Reactant |
2169485862 ns |
2267863268 ns |
0.96 |
ViT tiny (256 x 256 x 3 x 32)/forward/CPU/Lux |
4271876468 ns |
4660275687.5 ns |
0.92 |
ViT tiny (256 x 256 x 3 x 4)/forward/CUDA/Reactant |
1316968758 ns |
1374725656.5 ns |
0.96 |
ViT tiny (256 x 256 x 3 x 4)/forward/CUDA/Lux |
7464719.5 ns |
7919007 ns |
0.94 |
ViT tiny (256 x 256 x 3 x 4)/forward/CPU/Reactant |
1471509052 ns |
1523146334.5 ns |
0.97 |
ViT tiny (256 x 256 x 3 x 4)/forward/CPU/Lux |
1559028201 ns |
1657446563 ns |
0.94 |
ViT tiny (256 x 256 x 3 x 16)/forward/CUDA/Reactant |
1345744439.5 ns |
1293396969 ns |
1.04 |
ViT tiny (256 x 256 x 3 x 16)/forward/CUDA/Lux |
11653564 ns |
84573801 ns |
0.14 |
ViT tiny (256 x 256 x 3 x 16)/forward/CPU/Reactant |
1754843139 ns |
1829891224 ns |
0.96 |
ViT tiny (256 x 256 x 3 x 16)/forward/CPU/Lux |
2487275309.5 ns |
3023920644 ns |
0.82 |
ViT small (256 x 256 x 3 x 16)/forward/CUDA/Reactant |
1545602240 ns |
1292433719 ns |
1.20 |
ViT small (256 x 256 x 3 x 16)/forward/CUDA/Lux |
95539755.5 ns |
88498026 ns |
1.08 |
ViT small (256 x 256 x 3 x 16)/forward/CPU/Reactant |
2229052978 ns |
2315496105 ns |
0.96 |
ViT small (256 x 256 x 3 x 16)/forward/CPU/Lux |
3716833384.5 ns |
4181219607 ns |
0.89 |
ViT small (256 x 256 x 3 x 32)/forward/CUDA/Reactant |
1317185684 ns |
1367617841 ns |
0.96 |
ViT small (256 x 256 x 3 x 32)/forward/CUDA/Lux |
122600223 ns |
113824695 ns |
1.08 |
ViT small (256 x 256 x 3 x 32)/forward/CPU/Reactant |
3091138651 ns |
3118475424 ns |
0.99 |
ViT small (256 x 256 x 3 x 32)/forward/CPU/Lux |
6307106053.5 ns |
6707702872 ns |
0.94 |
ViT base (256 x 256 x 3 x 16)/forward/CUDA/Reactant |
1314407457 ns |
1342010577 ns |
0.98 |
ViT base (256 x 256 x 3 x 16)/forward/CUDA/Lux |
128864521.5 ns |
129882165.5 ns |
0.99 |
ViT base (256 x 256 x 3 x 16)/forward/CPU/Reactant |
3260848845 ns |
3304575961 ns |
0.99 |
ViT base (256 x 256 x 3 x 16)/forward/CPU/Lux |
7279675017 ns |
9641559937 ns |
0.76 |
ViT base (256 x 256 x 3 x 4)/forward/CUDA/Reactant |
1382526551 ns |
1318534127.5 ns |
1.05 |
ViT base (256 x 256 x 3 x 4)/forward/CUDA/Lux |
86162139 ns |
87600441 ns |
0.98 |
ViT base (256 x 256 x 3 x 4)/forward/CPU/Reactant |
2330506538 ns |
1971771485 ns |
1.18 |
ViT base (256 x 256 x 3 x 4)/forward/CPU/Lux |
2552811939.5 ns |
2525837503 ns |
1.01 |
This comment was automatically generated by workflow using github-action-benchmark.
Benchmark Results
Benchmark PlotsA plot of the benchmark results have been uploaded as an artifact to the workflow run for this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
compile
methods generate the same return types no matter the arguments. By adding@nospecialize
and maybe@nospecializeinfer
, maybe we can reduce the TTFX oncompile
when changing functions.