-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add Ops.batch
#535
base: main
Are you sure you want to change the base?
feat: add Ops.batch
#535
Conversation
d230dac
to
93c8534
Compare
8379431
to
037fd11
Compare
Project.toml
Outdated
@@ -9,6 +9,7 @@ CEnum = "fa961155-64e5-5f13-b03f-caf6b980ea82" | |||
Downloads = "f43a241f-c20a-4ad4-852c-f6b1247861c6" | |||
Enzyme = "7da242da-08ed-463a-9acd-ee780be4f1d9" | |||
EnzymeCore = "f151be2c-9106-41f4-ab19-57ee4f262869" | |||
Functors = "d9f16b24-f501-4c13-a1f2-28368ffc5196" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried not using functors 9ef1fff
(#535) but it gets quite messy and I couldn't figure out how to reconstruct arguments with corrected batch dims
This is going to be a fun rebase 😓 |
oof yeah, the "lets speed up to_rarray" just got in (and cut down time from minutes to seconds for big cases I tested on) |
96edbe0
to
a5ee635
Compare
@@ -0,0 +1,2 @@ | |||
using Reactant, Test | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[JuliaFormatter] reported by reviewdog 🐶
@@ -138,7 +138,7 @@ function make_mlir_fn( | |||
args[i], | |||
(:args, i), | |||
concretein ? Reactant.ConcreteToTraced : Reactant.TracedSetPath; | |||
toscalar, | |||
batchmode |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[JuliaFormatter] reported by reviewdog 🐶
batchmode | |
batchmode, |
4c24ec2
to
38a29ed
Compare
TracedRArray{unwrapped_eltype(dest),ndims(dest)}, | ||
TracedUtils.elem_apply(bc.f, args...), | ||
Ops.elem_apply(bc.f, args...), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[JuliaFormatter] reported by reviewdog 🐶
TracedRArray{unwrapped_eltype(dest),ndims(dest)}, | |
TracedUtils.elem_apply(bc.f, args...), | |
Ops.elem_apply(bc.f, args...), | |
TracedRArray{unwrapped_eltype(dest),ndims(dest)}, Ops.elem_apply(bc.f, args...) |
upstream issues: EnzymeAD/Enzyme-JAX#239
Example
TODOs: