Feature: allow colon indexing of traced **vectors**

[floffy-f]

Description of the problem

In the case in which one wants to set inplace a vector (so its dimension is (N,)) into some target traced vector with the colon-index operator, there is an ambigüity between two function signatures:

Base.setindex!(a::TracedRArray{T,N}, v, ::Colon) where {T,N}

and

const N = 1
Base.setindex!(a::TracedRArray{T,N}, v, indices::Vararg{Any,N}) where {T,N}

MWE

using Reactant

function ipop!(y, x)
    y[:] = x
end
x = Reactant.to_array([1.0, 2.0])
y = similar(x)
@jit ipop!(y, x)

ERROR: MethodError: setindex!(::Reactant.TracedRArray{Float64, 1}, ::Reactant.TracedRArray{Float64, 1}, ::Colon) is ambiguous.

Candidates:
setindex!(a::Reactant.TracedRArray{T, N}, v, ::Colon) where {T, N}
@ Reactant.TracedRArrayOverrides ~/.julia/packages/Reactant/B09Ss/src/TracedRArray.jl:271
setindex!(a::Reactant.TracedRArray{T, N}, v, indices::Vararg{Any, N}) where {T, N}
@ Reactant.TracedRArrayOverrides ~/.julia/packages/Reactant/B09Ss/src/TracedRArray.jl:295

Solution

I tested the solution in test/indexing.jl.
The function from the first signature is removed, and a check is added at the beginning of the second one to execute the same code as the deleted function.