Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change to dialect generator #691

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

glou-nes
Copy link
Contributor

@glou-nes glou-nes commented Feb 5, 2025

rebase #660 & #447. @mofeing I messed up #660 so I open a new PR.
Several modifications:

  • renaming result_ to result
  • apply the typing defining in args, for instance: result_layouts=nothing::Union{Attribute, Nothing} doesn't constraint result_layouts so change to : result_layouts::Union{Attribute, Nothing} =nothing
  • create Julia enum for EnumAttr : using Attr parsing (MLIR doesn't expose methods in C to easily construct arbitrary attribute) and discriminant.
  • typing Attribute and use Julia type for easy ones (Int, Float, Vector).
  • more complex Attributes ("struct" layout) such as conv
  • add an AbstractAttributes type

src/mlir/MLIR.jl Outdated Show resolved Hide resolved
Copy link

codecov bot commented Feb 7, 2025

Codecov Report

Attention: Patch coverage is 22.44318% with 546 lines in your changes missing coverage. Please review.

Project coverage is 37.88%. Comparing base (b6ffc96) to head (ca6546b).
Report is 394 commits behind head on main.

Files with missing lines Patch % Lines
src/mlir/Dialects/Nvvm.jl 0.00% 141 Missing ⚠️
src/mlir/Dialects/VHLO.jl 0.00% 58 Missing ⚠️
src/mlir/IR/Attribute.jl 41.57% 52 Missing ⚠️
src/mlir/Dialects/StableHLO.jl 54.28% 48 Missing ⚠️
src/mlir/Dialects/TPU.jl 0.00% 46 Missing ⚠️
src/mlir/Dialects/Llvm.jl 4.76% 40 Missing ⚠️
src/mlir/Dialects/CHLO.jl 28.26% 33 Missing ⚠️
src/mlir/Dialects/Gpu.jl 0.00% 33 Missing ⚠️
src/mlir/Dialects/Triton.jl 0.00% 32 Missing ⚠️
src/mlir/Dialects/Arith.jl 0.00% 19 Missing ⚠️
... and 10 more
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #691       +/-   ##
===========================================
+ Coverage   21.66%   37.88%   +16.21%     
===========================================
  Files          46       75       +29     
  Lines        8048    15152     +7104     
===========================================
+ Hits         1744     5741     +3997     
- Misses       6304     9411     +3107     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants