Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rebase #660 & #447. @mofeing I messed up #660 so I open a new PR.
Several modifications:
result_
toresult
result_layouts=nothing::Union{Attribute, Nothing}
doesn't constraintresult_layouts
so change to :result_layouts::Union{Attribute, Nothing} =nothing
EnumAttr
: using Attr parsing (MLIR doesn't expose methods in C to easily construct arbitrary attribute) and discriminant.conv